Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(card): Use on-surface color for action icons #4519

Merged
merged 6 commits into from
Mar 25, 2019

Conversation

kfranqueiro
Copy link
Contributor

Fixes #4238.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit 7ce5207:

Details

@kfranqueiro
Copy link
Contributor Author

I checked with design on this while I was asking about #4520, and this should be on-surface with 87% opacity (high emphasis).

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit f61e457:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit f61e457:

Details

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from master on commit 79bb8a4:

Details

@kfranqueiro kfranqueiro merged commit 9f37016 into master Mar 25, 2019
@kfranqueiro kfranqueiro deleted the fix/card-on-surface branch March 25, 2019 22:14
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants