fix(shape): Add noflip comments, fix RTL for categories #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
approved these changes
Nov 27, 2018
| @if ($needs-flip) { | ||
| /* @noflip */ | ||
| } | ||
|
|
There was a problem hiding this comment.
is annotation with new line acceptable?
this generates
/* @noflip */
border-radius: mdc-shape-prop-value($radius);
instead of
/* @noflip */
border-radius: mdc-shape-prop-value($radius);
There was a problem hiding this comment.
I was wary of that too, but when I looked at the diff between the all-in-one CSS before and after, I didn't see any empty newlines generated by these changes.
|
All 663 screenshot tests passed for commit 735692b vs. |
|
All 663 screenshot tests passed for commit 3afff8e vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has 3 changes/fixes:
@noflipannotations to both the LTR and RTL emitted styles when both are emitted