Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(drawer): Fix exports and closure tests #3424

Merged
merged 5 commits into from
Aug 27, 2018
Merged

Conversation

kfranqueiro
Copy link
Contributor

First of all, thanks so much @trimox for spotting this in #3422 before we even released!

This builds off of #3422 to fix closure tests, and also fix unit tests to reference mocks where needed.

@kfranqueiro kfranqueiro requested a review from abhiomkar August 27, 2018 14:31
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@kfranqueiro
Copy link
Contributor Author

@trimox can you give an OK in this PR since I based the branch off of your commits from #3422? Thanks!

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit a3adf0b vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3aa211d). Click here to learn what that means.
The diff coverage is 86.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3424   +/-   ##
========================================
  Coverage          ?   98.3%           
========================================
  Files             ?     119           
  Lines             ?    5017           
  Branches          ?     613           
========================================
  Hits              ?    4932           
  Misses            ?      85           
  Partials          ?       0
Impacted Files Coverage Δ
packages/mdc-drawer/util.js 100% <100%> (ø)
packages/mdc-drawer/index.js 97.05% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa211d...a3adf0b. Read the comment docs.

@trimox
Copy link
Contributor

trimox commented Aug 27, 2018

OK by me. 👍

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kfranqueiro kfranqueiro merged commit 8d53068 into master Aug 27, 2018
@kfranqueiro kfranqueiro deleted the fix/drawer-closure branch August 27, 2018 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants