-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(drawer): Fix exports and closure tests #3424
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
All 349 screenshot tests passed for commit a3adf0b vs. |
Codecov Report
@@ Coverage Diff @@
## master #3424 +/- ##
========================================
Coverage ? 98.3%
========================================
Files ? 119
Lines ? 5017
Branches ? 613
========================================
Hits ? 4932
Misses ? 85
Partials ? 0
Continue to review full report at Codecov.
|
OK by me. 👍 |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
First of all, thanks so much @trimox for spotting this in #3422 before we even released!
This builds off of #3422 to fix closure tests, and also fix unit tests to reference mocks where needed.