Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(text-field): Remove unnecessary styling on label in disabled state #2058

Merged
merged 4 commits into from
Jan 24, 2018

Conversation

lynnmercier
Copy link
Contributor

The label already sets bottom: 8px in mdc-text-field-label.scss. So it seems unnecessary to override that in mdc-text-field--disabled

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #2058 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
- Coverage   99.43%   99.43%   -0.01%     
==========================================
  Files          84       84              
  Lines        3720     3718       -2     
  Branches      485      485              
==========================================
- Hits         3699     3697       -2     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-slider/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-menu/foundation.js
packages/mdc-menu/index.js
packages/mdc-menu/constants.js
packages/mdc-menu/simple/index.js 100% <0%> (ø)
packages/mdc-menu/simple/foundation.js 99.26% <0%> (ø)
packages/mdc-menu/simple/constants.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793dcdf...497e0fa. Read the comment docs.

@kfranqueiro
Copy link
Contributor

Hm. Yeah I'm not sure why that style was there. Also I think removing this line might also allow you to remove lines for disabled box/outlined which are simply there to override this back to the value they would otherwise have inherited?

@lynnmercier
Copy link
Contributor Author

Sure, removed extra styling from the disabled outlined and box...and I removed some extra styling from the dense box

@lynnmercier lynnmercier merged commit 23e6b26 into master Jan 24, 2018
@lynnmercier lynnmercier deleted the fix/text-field/label branch January 24, 2018 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants