Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TabLayout] ripple of TabLayout is different from ripple of other components #3157

Open
manabu-nakamura opened this issue Dec 26, 2022 · 1 comment · May be fixed by #4296
Open

[TabLayout] ripple of TabLayout is different from ripple of other components #3157

manabu-nakamura opened this issue Dec 26, 2022 · 1 comment · May be fixed by #4296
Labels
bug Issue: Design Spec Mismatch Component does not match spec guidelines in some way

Comments

@manabu-nakamura
Copy link
Contributor

manabu-nakamura commented Dec 26, 2022 •
edited
Loading

Description:
Ripple of TabLayout is different from ripple of other components.
Catalog app:
i
https://m3.material.io/components/navigation-drawer/specs:
unnamed
cfc307e

Expected behavior:
https://m3.material.io/components/tabs/guidelines:

lxekv2yr-GM3-Components-Tabs-Guidelines-3-v01.mp4

Ripples of TabLayout are inconsistent in https://m3.material.io/components/tabs/guidelines:
lxekp043-18

Minimal sample app repro: Catalog app

Android API version: 33

Material Library version: 1.8.0-beta01

Device: 31.3.14
@drchen drchen added the Issue: Design Spec Mismatch Component does not match spec guidelines in some way label Jan 31, 2023
@drchen
Copy link
Contributor

drchen commented Jan 31, 2023

I actually feel the figure that shows tab states is wrong. Let us double check with our designers.

@manabu-nakamura manabu-nakamura linked a pull request Sep 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue: Design Spec Mismatch Component does not match spec guidelines in some way
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TabLayout] (proposal) ripple manabu-nakamura/material-components-android
2 participants
@drchen @manabu-nakamura