Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more efficient validation function #177

Closed
florian-huber opened this issue Jan 23, 2024 · 1 comment
Closed

Add more efficient validation function #177

florian-huber opened this issue Jan 23, 2024 · 1 comment
Assignees

Comments

@florian-huber
Copy link
Contributor

Currently we use a generator for the training (which is good), but also for the validation step.
The later is not ideal as @niekdejonge pointed out.
We will only see one (or several if we want) fix batches, but that probably is not describing our complex data well enough.

It is probably better to add an efficient computation of an all-vs-all validation spectra comparison. This, together with a binned computation of mse/rmse.

@florian-huber florian-huber self-assigned this Jan 23, 2024
@florian-huber
Copy link
Contributor Author

Has been added with #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant