README.md

Solution

1. decided to separate User and Job Offer

• https://github.com/mat-mik/dna-task/tree/master/src/main/java/com/example/dnatask/user
• https://github.com/mat-mik/dna-task/tree/master/src/main/java/com/example/dnatask/joboffer

These two modules definitely have different reasons for change, one domain (user) is heavily generic (replaceable with an off-the-shelf solution); the other domain looks like a core.

2. decided to extract Listing from JobOffer

   dna-task/src/main/java/com/example/dnatask/joboffer/job/model/JobOffer.java

   Lines 16 to 33 in 3422152

   	@Entity
   	public class JobOffer {
   	@Id
   	@GeneratedValue
   	private long id;
   	@Enumerated(EnumType.STRING)
   	private Category category;
   	private Instant startDate;
   	private Instant endDate;
   	@OneToOne
   	@JoinColumn(name = "employee_id",
   	referencedColumnName = "id")
   	private Employer employer;

dna-task/src/main/java/com/example/dnatask/joboffer/listing/JobListing.java

Lines 10 to 18 in 3422152

	@Entity
	public class JobListing {
	@Id
	private long offerId;
	private Category category;
	private String employer;

It simplifies read model (less fields - no need for startDate, endDate or employerId), prepares domain to be rewritten with better tools at the expense of data synchronization.

Missing parts / Improve area

• User's data (e.g. username/password). Only name was added.
• Missing test cases - https://github.com/mat-mik/dna-task/blob/master/src/test/java/com/example/dnatask/joboffer/JobOfferIntegrationTest.java
• Synchronization Offer -> Listing code:

  • dna-task/src/main/java/com/example/dnatask/joboffer/job/JobOfferSynchronizationScheduler.java

    Line 6 in 3422152

    public class JobOfferSynchronizationScheduler {

  • dna-task/src/main/java/com/example/dnatask/joboffer/job/JobOfferService.java

    Line 64 in 3422152

    public void deleteEmployer(long employerId) {

  • dna-task/src/main/java/com/example/dnatask/joboffer/job/JobOfferService.java

    Line 72 in 3422152

    public void updateEmployer(long employerId, String newName) {

• Naive query model

  dna-task/src/main/java/com/example/dnatask/joboffer/listing/JobListingService.java

  Lines 39 to 50 in 3422152

  	// TODO refactor to more sophisticated solution, e.g. Specification
  	public List<JobListing> findBy(@Nullable Category category, @Nullable String employerName) {
  	log.info("Listing job offers by (category: '{}', employerName: '{}')", category, employerName);
  	if (nonNull(category) && nonNull(employerName)) {
  	return jobListingRepository.findAllByCategoryAndEmployer(category, employerName);
  	} else if (nonNull(category)) {
  	return jobListingRepository.findAllByCategory(category);
  	} else if (nonNull(employerName)) {
  	return jobListingRepository.findAllByEmployer(employerName);
  	} else {
  	return jobListingRepository.findAll();
  	}

• Cleanup:
  • use more observable behaviour to do assertions

    dna-task/src/test/java/com/example/dnatask/user/UserServiceIntegrationTest.java

    Lines 125 to 129 in 3422152

    	private void userWasUpdated(long userId, String newName) {
    	User updatedUser = userRepository.findById(userId).orElseThrow();
    	assertThat(updatedUser.getName())
    	.isEqualTo(newName);
    	}

  • add missing then sections

    dna-task/src/test/java/com/example/dnatask/joboffer/JobOfferIntegrationTest.java

    Lines 128 to 129 in 3422152

    	jobListeningContains(listings, dnaVisibleITOfferId);
    	jobListeningDoesNotContain(listings, avengaVisibleShopOfferId);