Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toot menus are unaware of user mute/block state #10514

Closed
trwnh opened this issue Apr 8, 2019 · 3 comments
Closed

Toot menus are unaware of user mute/block state #10514

trwnh opened this issue Apr 8, 2019 · 3 comments
Labels
partially a bug Architecture or design-imposed shortcomings

Comments

@trwnh
Copy link
Member

trwnh commented Apr 8, 2019

Steps to reproduce the problem

  1. Load the "Muted users" list.
  2. Load a user from the "Muted users" list.
  3. Note that the 3dot menu correctly lists "Unmute user" as an option.
  4. View that user's "Toots and replies" tab.
  5. Open any reply by that user, or any toot that contains a reply from that user.
  6. Note that the 3dot menu on the user's toot incorrectly shows "Mute user", as if they are not already muted. Alternatively, note that the user's toot is visible at all in the thread context.

Expected behavior

  • When viewing from a profile, muted/blocked state is reflected in status menus.
  • When viewing from a thread, both blocked and muted users are hidden/removed.

Actual behavior

  • When viewing from a profile, muted/blocked state is not reflected in status menus.
  • When viewing in a thread, blocked users are removed, but muted users are still visible until blocked. User toots remain removed even after unblocked, though.

Specifications

mastodon.social v2.8.0rc1, unsure how far it goes back. There may be other side effects.

@Gargron Gargron added the partially a bug Architecture or design-imposed shortcomings label May 1, 2019
@trwnh
Copy link
Member Author

trwnh commented Oct 7, 2019

Presumably Relationship is not cached via the api; maybe it should be?

@Gargron
Copy link
Member

Gargron commented Oct 7, 2019

The solution should be that opening the toot dropdown would send a relationship API request. That would allow us to put "follow" option on toot dropdowns as well.

@ClearlyClaire
Copy link
Contributor

Fixed by #12377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partially a bug Architecture or design-imposed shortcomings
Projects
None yet
Development

No branches or pull requests

3 participants