Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM compiler options are wrong #53

Open
knell opened this issue Dec 13, 2021 · 3 comments
Open

ARM compiler options are wrong #53

knell opened this issue Dec 13, 2021 · 3 comments

Comments

@knell
Copy link

knell commented Dec 13, 2021

16:37:39 [ 8%] Building C object PFFFT/CMakeFiles/PFFFT.dir/pffft_double.c.o
16:37:39 arm-buildroot-linux-gnueabihf-gcc.br_real: error: unrecognized command-line option '-msse2'

Starting from line 170 in CMakeLists.txt there is no check for arm platforms, like this:

elseif(CMAKE_COMPILER_IS_GNUCC AND NOT USE_SIMD_NEON)

@marton78
Copy link
Owner

Hi @knell, thank you for the bug report. I don't have time to take care of it, but I'm happy to accept pull requests.

@knell
Copy link
Author

knell commented Dec 15, 2021

Well, the problem is that the -march=native does not work as well, it's not a valid option too. I have fixed it using the particular armv7 architecture but that's not the proper fix in general, of course. It should be some precise platform detection I guess to use that option properly.

@hayguen
Copy link
Collaborator

hayguen commented Apr 8, 2022

would you please check this again? (after my big changes in the cmake files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants