Mas d34 leveled.i465 stopfold #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test previously fails, as even on a fast machine the fold goes on for 5s beyond the last object found. With change to reduce batch size, and stop when batch goes beyond JournalSQN - success with << 100ms spent folding after the last object discovered
As the key changes are going to be discarded
ThomasArts
reviewed
Jan 14, 2025
ThomasArts
approved these changes
Jan 14, 2025
martinsumner
added a commit
to OpenRiak/leveled
that referenced
this pull request
Jan 15, 2025
* Test and fix - issue with folding beyond JournalSQN Test previously fails, as even on a fast machine the fold goes on for 5s beyond the last object found. With change to reduce batch size, and stop when batch goes beyond JournalSQN - success with << 100ms spent folding after the last object discovered * Wait after suite for delete_pending to close martinsumner#462 * Avoid processing key changes in object fold runner As the key changes are going to be discarded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve efficiency of fold_objects sqn_order - and hence efficiency of handoffs in Riak
#465
(also includes - #462)
The
riak_SUITE:handoff_close/1test would previously fail, as there would be around 5s of time processing changes after the fold to the JournalSQN has finished. It now tests that this is less than 1s (on a fats machine should be < 10ms).The batch size has also bene reduced to alternate more frequently between pushing disk and pushing CPU.