Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgcat not working in tmux 3.4 due to unrecognised $TERM value #1

Open
mkgessen opened this issue Oct 13, 2024 · 1 comment
Open

imgcat not working in tmux 3.4 due to unrecognised $TERM value #1

mkgessen opened this issue Oct 13, 2024 · 1 comment

Comments

@mkgessen
Copy link

Hi @martinlindhe,

Thanks for the lovely library! I noticed that imgcat doesn't work in tmux v3.4, as $TERM yields tmux-256color instead of screen.

The current implementation imgcat.embed() requires os.Getenv("TERM") == "screen" to add the DCS tmux magic. Everything works on tmux 3.4 if I add tmux-256color to the recognized $TERM options.

I can submit a PR if you're interested?

$ tmux -V
tmux 3.4
$ echo $TERM
tmux-256color
$ uname -rm
6.10.10-arch1-1 x86-64
@martinlindhe
Copy link
Owner

martinlindhe commented Oct 15, 2024

Please continue the discussion with said PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants