[BUG/ISSUE] Packages in "Discover Packages" are not properly selected outside the currently visible search page

[Nereithr]

Before submitting the issue

• I have checked that the bug is not a duplicate or, if it is, it needs to be reopened
• I have checked that I am running the latest version of WingetUI
• I have tried resetting and reinstalling WingetUI and the issue persisted or happened again
• I have checked the FAQ section for solutions
• I have read the contributing guidelines and I agree with the Code of Conduct

Describe the bug

1. Packages in "Discover Packages" can only be interacted with (installed, selection cleared, etc.) if they are present in the currently loaded searchlist. If you select multiple different packages far apart from each other (in my current test ATLauncher, Kate, Obsidian), then cancel to the default "" search, it will only install the visible package (ATLauncher).
2. If no visible item is selected, nothing happens.
3. Attempting to clear selection will only clear selection from visible items, searching for the previously selected packages shows that they are still selected.

To Reproduce

Install multiple packages

1. Go to "Discover Packages"
2. Select ATLauncher (or any other already loaded item in the search)
3. Search for Kate
4. Select Kate
5. Search for Obsidian
6. Select Obsidian
7. Click Install Selected
8. Only ATLauncher will get installed

No visible item selected

11. Uncheck ATLauncher
12. Click Install Selected
13. Nothing happens

Clear selection not clearing selection from non-loaded items

14. Click "Clear Selection"
15. Search for Kate
16. Kate is still selected
17. Search for Obsidian
18. Obsidian is still selected
19. Click "Clear Selection"
20. Obsidian is deselected when on-screen

Expected behaviour

Selection persists between searches and interactions in "Discover Packages" do not depend on what is visible on screen. If ATLauncher, Obsidian and Kate are searched for and selected, they should be installable/selection should be clearable regardless of whether or not they are currently visible on screen.

The Log

C:\Users\sol\AppData\Local\Programs\WingetUI\sudo\gsudo.exe
C:\Users\sol\AppData\Local\Programs\WingetUI\sudo
🟢 checkQueue Thread started!
🟢 Using cached lang file
🟡 Using bundled lang file (forced=True)
It took 0.030649185180664062 to load all language files
🔵 Starting main application...
Scanning for instances...
Found lock file(s), reactivating...
🔵 Starting update check
b'v1.4.10173\r\n'
None
updating winget
🔵 Language file up-to-date
🟢 Downloaded latest metadata to local file
🔵 Loaded metadata from local file
🔵 Version URL: https://versions.marticliment.com/versions/wingetui.ver
🟢 Updates found!
Reactivation signal ignored: RaiseWindow_[1678973520.412811]
{'wingetFound': True, 'scoopFound': False, 'chocoFound': False, 'sudoFound': True, 'wingetVersion': 'v1.4.10173\r', 'scoopVersion': 'Scoop is disabled', 'chocoVersion': 'Chocolatey is disabled', 'sudoVersion': 'gsudo v2.0.4 (Branch.tags-v2.0.4.Sha.506efa024af0cef6e4b0cfec42e0c8c5d0b1472c)\r'}
Reached main ui load milestone
🔵 Is Dark
Can't disconnect
🟢 Starting winget search, winget on C:\Users\sol\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Discover tab loaded
Can't disconnect
🟢 Starting winget search, winget on C:\Users\sol\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Upgrades tab loaded
Can't disconnect
🟢 Starting winget search, winget on C:\Users\sol\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Discover tab loaded
{'System language': 'default', 'Arabic - عربي\u200e (95%)': 'ar', 'Bulgarian - български (88%)': 'bg', 'Bangla - বাংলা (25%)': 'bn', 'Catalan - Català': 'ca', 'Czech - Čeština (95%)': 'cs', 'Danish - Dansk (47%)': 'da', 'German - Deutsch (88%)': 'de', 'English - English': 'en', 'Spanish - Castellano': 'es', 'French - Français': 'fr', 'Hindi - हिंदी (76%)': 'hi', 'Hungarian - Magyar': 'hu', 'Italian - Italiano': 'it', 'Indonesian - Bahasa Indonesia (22%)': 'id', 'Japanese - 日本語 (82%)': 'ja', 'Korean - 한국어 (92%)': 'ko', 'Dutch - Nederlands (95%)': 'nl', 'Polish - Polski (95%)': 'pl', 'Portuguese (Brazil) (95%)': 'pt_BR', 'Portuguese (Portugal) (95%)': 'pt_PT', 'Russian - Русский (76%)': 'ru', 'Serbian - Srpski (20%)': 'sr', 'Turkish - Türkçe (79%)': 'tr', 'Ukranian - Yкраї́нська (79%)': 'ua', 'Simplified Chinese (China) (95%)': 'zh_CN', 'Traditional Chinese (Taiwan) (95%)': 'zh_TW'}
['System language', 'Arabic - عربي\u200e (95%)', 'Bulgarian - български (88%)', 'Bangla - বাংলা (25%)', 'Catalan - Català', 'Czech - Čeština (95%)', 'Danish - Dansk (47%)', 'German - Deutsch (88%)', 'English - English', 'Spanish - Castellano', 'French - Français', 'Hindi - हिंदी (76%)', 'Hungarian - Magyar', 'Italian - Italiano', 'Indonesian - Bahasa Indonesia (22%)', 'Japanese - 日本語 (82%)', 'Korean - 한국어 (92%)', 'Dutch - Nederlands (95%)', 'Polish - Polski (95%)', 'Portuguese (Brazil) (95%)', 'Portuguese (Portugal) (95%)', 'Russian - Русский (76%)', 'Serbian - Srpski (20%)', 'Turkish - Türkçe (79%)', 'Ukranian - Yкраї́нська (79%)', 'Simplified Chinese (China) (95%)', 'Traditional Chinese (Taiwan) (95%)']
en
{'default': 'System language', 'ar': 'Arabic - عربي\u200e (95%)', 'bg': 'Bulgarian - български (88%)', 'bn': 'Bangla - বাংলা (25%)', 'ca': 'Catalan - Català', 'cs': 'Czech - Čeština (95%)', 'da': 'Danish - Dansk (47%)', 'de': 'German - Deutsch (88%)', 'en': 'English - English', 'es': 'Spanish - Castellano', 'fr': 'French - Français', 'hi': 'Hindi - हिंदी (76%)', 'hu': 'Hungarian - Magyar', 'it': 'Italian - Italiano', 'id': 'Indonesian - Bahasa Indonesia (22%)', 'ja': 'Japanese - 日本語 (82%)', 'ko': 'Korean - 한국어 (92%)', 'nl': 'Dutch - Nederlands (95%)', 'pl': 'Polish - Polski (95%)', 'pt_BR': 'Portuguese (Brazil) (95%)', 'pt_PT': 'Portuguese (Portugal) (95%)', 'ru': 'Russian - Русский (76%)', 'sr': 'Serbian - Srpski (20%)', 'tr': 'Turkish - Türkçe (79%)', 'ua': 'Ukranian - Yкраї́нська (79%)', 'zh_CN': 'Simplified Chinese (China) (95%)', 'zh_TW': 'Traditional Chinese (Taiwan) (95%)'}
Can't disconnect
🟢 Settings tab loaded!
🟢 About tab loaded!
🟢 Main application loaded...
Name           Id             Version       Available
🟢 Winget search finished
🟢 Searching for string ""
🟢 Searching for string ""
🟡 Can't get custom interval time! (got value was '')
🟢 Total packages: 4
🟢 Winget uninstallable packages search finished
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 132
None
🟢 Winget search finished
🟢 Total packages: 4314
🔵 Hash:  b99f9498144731d6965dbd223863279b18eedd4eac6107a4d77ff0c7172fbce9
🟢 Hash ok, starting update
🔵 Copying log to the clipboard...
🟢 Log copied to the clipboard successfully!
🟢 Searching for string "g"
🟢 Searching for string "ga"
🟢 Searching for string "g"
🟢 Searching for string ""
🟢 Searching for string "c"
🟢 Searching for string "cu"
🟢 Searching for string "cub"
🟢 Searching for string "cube"
🟢 Searching for string "g"
🟢 Searching for string "ga"
🟢 Searching for string "gam"
🟢 Searching for string "gami"
🟢 Searching for string "gamin"
🟢 Searching for string "gaming"
🟢 Searching for string ""
🟢 Searching for string "e"
🟢 Searching for string "ea"
🟢 Searching for string "eas"
🟢 Searching for string "easy"
🟢 Searching for string ""
🟢 Searching for string "l"
🟢 Searching for string "li"
🟢 Searching for string "l"
🟢 Searching for string ""
🟢 Searching for string "l"
🟢 Searching for string "li"
🟢 Searching for string "lig"
🟢 Searching for string "ligh"
🟢 Searching for string "light"
🟢 Searching for string "lightw"
🟢 Searching for string "o"
🟢 Searching for string ""
🟢 Searching for string "o"
🟢 Searching for string "ob"
🟢 Searching for string "obs"
🟢 Searching for string "obs"
🟢 Searching for string ""
🟢 Searching for string "a"
🟢 Searching for string "at"
🟢 Searching for string "atl"
🟢 Searching for string "atla"
🟢 Searching for string "atla"
🟢 Searching for string "m"
🟢 Searching for string "ma"
🟢 Searching for string "mat"
🟢 Searching for string "matl"
🟢 Searching for string "mat"
🟢 Searching for string ""
🟢 Searching for string "o"
🟢 Searching for string "on"
🟢 Searching for string "one"
🟢 Searching for string "oned"
🟢 Searching for string "onedr"
🟢 Searching for string ""
🟢 Searching for string "p"
🟢 Searching for string "pa"
🟢 Searching for string "pat"
🟢 Searching for string "patc"
🟢 Searching for string "patch"
🟢 Searching for string ""
🟢 Searching for string "e"
🟢 Searching for string "ex"
🟢 Searching for string "exp"
🟢 Searching for string "expl"
🟢 Searching for string "explo"
🟢 Searching for string "explor"
🟢 Searching for string "explore"
🟢 Searching for string "explorer"
🟢 Searching for string "k"
🟢 Searching for string "ka"
🟢 Searching for string "kat"
🟢 Searching for string "kate"
🟢 Searching for string "kate"
🟢 Searching for string ""
args
🟢 Waiting for install permission... title=ATLauncher Setup, id=ATLauncher.ATLauncher, installId=1678974919.1690397
🟢 Searching for string ""
🔵 Current program set to 1678974919.1690397
🟢 Have permission to install, starting installation threads...
['C:\\Users\\sol\\AppData\\Local\\Programs\\WingetUI\\winget-cli\\winget.exe', 'install', '-e', '--id', 'ATLauncher.ATLauncher', '--source', 'winget', '--accept-source-agreements', '--silent', '--force']
🟢 winget installer assistant thread started for process <Popen: returncode: None args: ['C:\\Users\\sol\\AppData\\Local\\Programs\\W...>
🟢 Searching for string "k"
🟢 Searching for string "ka"
🟢 Searching for string "kat"
🟢 Searching for string "kate"
🟢 Searching for string "o"
🟢 Searching for string "ov"
🟢 Searching for string "o"
🟢 Searching for string "ob"
🟢 Searching for string "obs"
🟢 Searching for string ""
🟢 Searching for string ""

Additional context

Reproducible on 1.6.2 and 1.6.3

[Mikey1993]

@marticliment
I think that this bug could have been evaded in before if the main "install package" icon would just install all the selected packages (the ones that are marked with a "V"), see my recommendation here #814

[marticliment]

Yes, but the issue here is related to from where items are picked.
The issue radicates on newer optimisations on the search engine

[Mikey1993]

Yes, but the issue here is related to from where items are picked. The issue radicates on newer optimisations on the search engine

I see 👍
By the way, looks like when winget-cli v1.5 version will be released (due to April), it will support multiple package installs with one single command, so it's something to keep an eye for to implement to use that.
See microsoft/winget-cli#219

[marticliment]

By the way, looks like when winget-cli v1.5 version will be released (due to April), it will support multiple package installs with one single command, so it's something to keep an eye for to implement to use that.

This is interersting. Thanks for pointing out!