Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main variable node contains hypen, it should be underscore #29

Closed
zaggash opened this issue Apr 14, 2021 · 3 comments
Closed

Main variable node contains hypen, it should be underscore #29

zaggash opened this issue Apr 14, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@zaggash
Copy link

zaggash commented Apr 14, 2021

Describe the bug
The hyphen in a variable name is not a POSIX standard

To Reproduce
export KEEL-TELEGRAM-BOT_KEEL_PASSWORD="mypassword"

Expected behavior
The variable should be created

Desktop (please complete the following information):

  • OS: Linux
@markusressel markusressel added the enhancement New feature or request label Apr 15, 2021
@markusressel
Copy link
Owner

Thx. Yeah I never really liked that anyway.

Since you are talking about the ENV variables I think this should be implemented in the config library container-app-conf (I will create an issue there). Since I do like it to be able to use the hyphen variant in the yaml config, allowing both the hyphen and underscore variant in the ENV source should fix this right?

@zaggash
Copy link
Author

zaggash commented Apr 15, 2021

Yeah, I think a conversion from hyphen to underscore in the config library is the way to go ;)
Thanks for taking care of it ;)

However, it will be a breaking change on this app tho for those like me who uses the current implementation.
Nevermind, I didn't pay attention you planned to allow both spelling.

@markusressel
Copy link
Owner

Should be fixed with the new release, report back if it isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants