Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing menu items when using v2 of library #25

Closed
barbeau opened this issue Feb 7, 2018 · 7 comments
Closed

Disappearing menu items when using v2 of library #25

barbeau opened this issue Feb 7, 2018 · 7 comments
Labels

Comments

@barbeau
Copy link
Contributor

barbeau commented Feb 7, 2018

Summary:

@markormesher I did a fairly straightforward port of our project to use v2 of this library - WIP PR at:
OneBusAway/onebusaway-android#856

However, I'm seeing different behavior in terms of the visibility of menu items.

If I tap on the "Bikeshare" menu item (see left screenshot below), the entire menu item disappears (see right screenshot below):

image

If I tap on the FAB twice (to close and re-open it) then the correct state is shown (i.e., after first tapping on the "Bikeshare" menu item, I would expect it to look like this instead of disappearing:

image

Is there new behavior in v2 that I'm missing that's causing this?

Steps to reproduce:

  1. Clone and pull in WIP PR at Migrate to android-fab v2.2.0 library OneBusAway/onebusaway-android#856
  2. Run gradlew assembleObaGoogleDebug or build this build variant via Android Studio
  3. Run app
  4. Tap on hamburger menu
  5. Tap on "Settings"
  6. Tap on "Your region" and choose Tampa
  7. Tap on "Layers" FAB button (top FAB in lower-right corner)
  8. Tap on "Bikeshare" menu item

Expected behavior:

"Bikeshare" menu item should stay visible and background should change from blue to gray, indicating that the layer is disabled

Observed behavior:

"Bikeshare" menu item disappears

Device and Android version:

Samsung Galaxy S8+ w/ Android 8.0 beta

@markormesher
Copy link
Owner

Hey, thanks for flagging this. Looks like should be a straightforward fix: the rebuildSpeedDialMenu method that you call in this block doesn't properly handle rebuilding the menu if it is still open. I'll take a look at this one tomorrow too!

@barbeau
Copy link
Contributor Author

barbeau commented Feb 7, 2018

Awesome, thanks @markormesher! And thanks for the great library!

@markormesher
Copy link
Owner

@markormesher
Copy link
Owner

Fixed in v2.2.0 👍

@barbeau
Copy link
Contributor Author

barbeau commented Feb 9, 2018

Thanks @markormesher! I'll give it a try.

@barbeau
Copy link
Contributor Author

barbeau commented Feb 9, 2018

@markormesher I only see v2.1.0 on JCenter:
https://bintray.com/markormesher/maven/android-fab

@markormesher
Copy link
Owner

My bad, should be published now: https://bintray.com/markormesher/maven/android-fab/v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants