-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disappearing menu items when using v2 of library #25
Comments
Hey, thanks for flagging this. Looks like should be a straightforward fix: the |
Awesome, thanks @markormesher! And thanks for the great library! |
https://github.com/markormesher/android-fab/compare/reposition-menu-items-when-rebuilt Will be merged + released this afternoon |
Fixed in v2.2.0 👍 |
Thanks @markormesher! I'll give it a try. |
@markormesher I only see v2.1.0 on JCenter: |
My bad, should be published now: https://bintray.com/markormesher/maven/android-fab/v2.2.0 |
Summary:
@markormesher I did a fairly straightforward port of our project to use v2 of this library - WIP PR at:
OneBusAway/onebusaway-android#856
However, I'm seeing different behavior in terms of the visibility of menu items.
If I tap on the "Bikeshare" menu item (see left screenshot below), the entire menu item disappears (see right screenshot below):
If I tap on the FAB twice (to close and re-open it) then the correct state is shown (i.e., after first tapping on the "Bikeshare" menu item, I would expect it to look like this instead of disappearing:
Is there new behavior in v2 that I'm missing that's causing this?
Steps to reproduce:
gradlew assembleObaGoogleDebug
or build this build variant via Android StudioExpected behavior:
"Bikeshare" menu item should stay visible and background should change from blue to gray, indicating that the layer is disabled
Observed behavior:
"Bikeshare" menu item disappears
Device and Android version:
Samsung Galaxy S8+ w/ Android 8.0 beta
The text was updated successfully, but these errors were encountered: