Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run spec tests with testutils #3017

Merged
merged 19 commits into from
Nov 11, 2023
Merged

fix: run spec tests with testutils #3017

merged 19 commits into from
Nov 11, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 2, 2023

Description

use @markedjs/testutils to run tests with node test runner

BREAKING CHANGE: test runner doesn't work in node v16

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 4:45am

test/bench.js Outdated Show resolved Hide resolved
@@ -0,0 +1,49 @@
import { Marked } from '../lib/marked.esm.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So an extension package will just need to make their own version of this file to run spec tests, right?

I'm most interested in spec tests, but is there a similar capability for running unit tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, there is a getAllMarkedSpecTests() method to get the marked specs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using that method in marked because we want to be able to run tests that are created in PRs.

Copy link
Member Author

@UziTech UziTech Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UziTech UziTech changed the title BREAKING CHANGE: test: run spec tests with testutils fix: run spec tests with testutils Nov 11, 2023
@UziTech UziTech merged commit 014d4e6 into markedjs:master Nov 11, 2023
8 checks passed
@UziTech UziTech deleted the testutils branch November 11, 2023 05:49
github-actions bot pushed a commit that referenced this pull request Nov 11, 2023
# [10.0.0](v9.1.6...v10.0.0) (2023-11-11)

### Bug Fixes

* run spec tests with testutils ([#3017](#3017)) ([014d4e6](014d4e6))

### BREAKING CHANGES

* drop support for node v16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants