Italics failing under certain cases

[AmarPrabhu]

Italics fails under many conditions:

• The markdown this is a simple _italics _without space <br> should yield HTML:

<p>this is a simple <em>italics </em>without space <br></p>

(as per http://daringfireball.net/projects/markdown/dingus)

instead marked gives me: <p>this is a simple _italics _without space <br></p>

• Another example of the same happening:
  Markdown: this is another _italics_without space
  Exp result: <p>this is another <em>italics</em>without space<br></p>
  Marked result: <p>this is another _italics_without space<br></p>
• Sometimes the parsing is completely broken:
  Markdown:

this is a simple _italics _without space <br> this is another _italics_without space<br> this is yet another _italics_ with space<br>

should yield:

<p>this is a simple <em>italics </em>without space <br>
this is another <em>italics</em>without space<br>
this is yet another <em>italics</em> with space<br></p>

Marked yields:

<p>this is a simple <em>italics _without space <br>
this is another _italics_without space<br>
this is yet another _italics</em> with space<br></p>

[ghost]

This is my options with https://github.com/chjj/marked/blob/ab84e8c6055b020f29134b93c86a9ae2ce955706/lib/marked.js:

{
  gfm: false,
  tables: false,  //need gfm
  breaks: false,  //need gfm
  pedantic: false,  // if it is true, my examples below will fail
  sanitize: true,  // if it is false, my examples below will fail
  smartLists: false,
  smartypants: false,
}

I found it even more strange:

this is another _italics _without space <br> becomes <p>this is another _italics _without space &lt;br&gt;</p> (nope)

this is another *italics *without space <br> becomes <p>this is another <em>italics </em>without space &lt;br&gt;</p> (yep)

this is another _italics_without space becomes <p>this is another _italics_without space</p> (nope)

this is another *italics*without space becomes <p>this is another <em>italics</em>without space</p> (yep)

Your example above is different with "*":

this is a simple *italics *without space <br>
this is another *italics*without space<br>
this is yet another *italics* with space<br>

becomes:

<p>this is a simple <em>italics </em>without space &lt;br&gt;
this is another <em>italics</em>without space&lt;br&gt;
this is yet another <em>italics</em> with space&lt;br&gt;</p>

[AmarPrabhu]

I just used the current library as is - no changes to the config. So * seems to be working fine huh. Let me give it a try and let you know. Thanks for the quick response.

[adam-p]

I did some tests with the MD dingus and with Marked with {gfm: false, pedantic: true} (which seem most original MD-ish).

this is a simple _italics _without space <br>
dingus: <p>this is a simple _italics _without space <br></p>
marked: <p>this is a simple _italics _without space <br></p>

this is another _italics_without space
dingus: <p>this is another <em>italics</em>without space</p>
marked: <p>this is another <em>italics</em>without space</p>

this is another _italics_without space<br>
dingus: <p>this is another <em>italics</em>without space<br></p>
marked: <p>this is another <em>italics</em>without space<br></p>

this is yet another _italics_ with space<br>
dingus: <p>this is yet another <em>italics</em> with space<br></p>
marked: <p>this is yet another <em>italics</em> with space<br></p>

So... looks to me like Marked is pretty accurate.

[AmarPrabhu]

I disagree @adam-p : Dingus does not produce the same results you have mentioned.

MD: this is a simple _italics _without space <br>
Dingus: <p>this is a simple <em>italics </em>without space <br></p>
Marked: <p>this is a simple _italics _without space<br></p>

Here is a screenshot of the output in Dingus:

Here's another example:
MD: this is another _italics_without space
Dingus: <p>this is another <em>italics</em>without space</p>
Marked: <p>this is another _italics_without space</p>
Output in Dingus:

[AmarPrabhu]

I tried * for italics and __ for bold and that seems to do the trick. The parsing works fine for that combination of the markdown spec. However I think the opposite combination - _ for italics and ** for bold needs work in marked.

[adam-p]

I dunno, man, I dunno.

My dingus from the first:

My Marked from the second:

And now I'm just going to back out of this discussion...

[joshbruce]

Closing as most likely covered by CommonMark compliance. See also #1106 and #1216