Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: use ReJSON #109

Open
prezmix opened this issue Mar 23, 2017 · 1 comment
Open

Feature Request: use ReJSON #109

prezmix opened this issue Mar 23, 2017 · 1 comment

Comments

@prezmix
Copy link

prezmix commented Mar 23, 2017

Redis has released a module for native JSON capabilities:

https://redislabs.com/blog/redis-as-a-json-store/

Would be nice to use this under the hood for the JSON data type?

@sam2x
Copy link
Collaborator

sam2x commented May 25, 2017

hmmm after reading the blogpost, I don't think perfomance will be improved.
According the article : "What happens under the hood is that whenever you call JSON.SET, the module takes the value through a streaming lexer that parses the input JSON and builds tree data structure from it".
So, performance seems to be impacted : actually Nohm just store a blob of json (as string with JSON.stringify iirc), and this module parse & builds a tree data structure. I guess there is benefit when you need to walk in this structured JSON and seek for specific data, but it seems irrelevant in Nohm context.

Plus, it will require nohm to depend on it, which imply that everyone will need to have a minimum redis version (3.x ?) and build this module before using Nohm (or it will require large modification to detect the module and adapt code context according its presence).
I'm not the author of Nohm, so see it just as a personal feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants