-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple entries or wildcards in allow_origin #24
Comments
I found But it seems to have a bug, which is fixed by: diff --git a/jupyter_server/base/handlers.py b/jupyter_server/base/handlers.py
index 60d0e5fea..81bf7b36b 100644
--- a/jupyter_server/base/handlers.py
+++ b/jupyter_server/base/handlers.py
@@ -295,7 +295,8 @@ class JupyterHandler(AuthenticatedHandler):
@property
def allow_origin_pat(self):
"""Regular expression version of allow_origin"""
- return self.settings.get("allow_origin_pat", None)
+ pat_str = self.settings.get("allow_origin_pat", None)
+ return re.compile(pat_str) if pat_str else None
@property
def allow_credentials(self): I can make a PR for this. After that, you should be able to use |
Oh cool. I completely missed the |
@mariobuikhuizen Any update on the PR fix for this? |
I think this is now fixed. |
Does the
Voila.tornado_settings
allow_origin
key allow multiple entries, or wildcards? In order to use the cookie passing feature, we set"allow_credentials": "true"
but with that, we can no longer use a general wildcard inallow_origin: "*"
. Does voila allow passing a list of allowed domains? or is there a syntax for specifying all subdomains. e.g.*.stsci.edu
? I couldn't find anything in the Jupyter server documentation.The text was updated successfully, but these errors were encountered: