Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlm_fbm #18

Closed
marcosci opened this issue Mar 1, 2018 · 1 comment
Closed

nlm_fbm #18

marcosci opened this issue Mar 1, 2018 · 1 comment
Assignees

Comments

@marcosci
Copy link
Collaborator

marcosci commented Mar 1, 2018

ropensci/software-review#188 (comment):

nlm_fbm:

Add in checkmate::assert_true(fract_dim > 0).

The code checks that fract_dim is < 2, but the help file states that this parameter is including 2 - fract_dim = numeric in (0, 2]

Values of fract_dim between ~1.56 and ~1.99 generate an error. This is caused by the RandomFields::RFsimulate function.

If this function is run with a random seed, it holds onto it until a new seed is set. This can be fixed by removing the if (!is.null(user_seed)) statement. The default user_seed = NULL will set the seed back to NA.

@mattfrit
Copy link
Contributor

mattfrit commented Mar 8, 2018

opened fix/18 branch. added check and seed reset.

the error with the alpha values is somewhere in rfInit. it is possible to produce output by switching modus_operandi to "sloppy"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants