Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See hotwired/turbo#684 #3

Closed
seanpdoyle opened this issue Aug 13, 2022 · 4 comments
Closed

See hotwired/turbo#684 #3

seanpdoyle opened this issue Aug 13, 2022 · 4 comments

Comments

@seanpdoyle
Copy link

I've opened hotwired/turbo#684, which changes the way that custom actions are defined from directly accessing StreamActions to defining a turbo:before-stream-render event listener.

If that change ships before a 7.2.0 release, this package will need to change how its morphdom integration is defined.

@marcoroth
Copy link
Owner

Thank you for the heads-up!

@drnic
Copy link

drnic commented Aug 22, 2022

Is this issue related to this error I'm seeing?

js     | ✘ [ERROR] No matching export in "../../node_modules/@hotwired/turbo/dist/turbo.es2017-esm.js" for import "StreamActions"
js     |
js     |     ../../node_modules/turbo-morph/dist/index.js:1:7:
js     |       1 │ import{StreamActions as e}from"@hotwired/turbo";var t;var n="undefi...
js     |         ╵        ~~~~~~~~~~~~~
js     |
js     | /Users/drnic/Projects/insurance-policies/insurance-policies/node_modules/esbuild/lib/main.js:1624
js     |   let error = new Error(`${text}${summary}`);
js     |               ^
js     |
js     | Error: Build failed with 1 error:
js     | ../../node_modules/turbo-morph/dist/index.js:1:7: ERROR: No matching export in "../../node_modules/@hotwired/turbo/dist/turbo.es2017-esm.js" for import "StreamActions"

I've on turbo-rails 7.1.3 / turbo 7.1.0.

@drnic
Copy link

drnic commented Aug 22, 2022

Ah, I see in the readme that I need to wait for turbo 7.2.0.

@marcoroth
Copy link
Owner

I think we can close this one since Turbo 7.2 ships with the StreamActions export and the turbo:before-stream-render event listener.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants