Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: packaging and organization #8

Closed
lheagy opened this issue Sep 17, 2018 · 0 comments
Closed

JOSS review: packaging and organization #8

lheagy opened this issue Sep 17, 2018 · 0 comments

Comments

@lheagy
Copy link

lheagy commented Sep 17, 2018

This is related to the installation (issue #7), and should be addressed before then. For python packaging, it is standard install the module as a single module and import packages from there (rather than individually installing each of the python scripts). e.g.

import grain_size_tools as gst
gst.extract_column()

This way there is less chance of name clash, and it is pretty clear what you are importing when.

I will start a pull request to give a few pointers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants