Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4: assertionerror in ont resolve graph #164

Closed
ptrebert opened this issue Jul 3, 2023 · 5 comments
Closed

v1.4: assertionerror in ont resolve graph #164

ptrebert opened this issue Jul 3, 2023 · 5 comments

Comments

@ptrebert
Copy link

ptrebert commented Jul 3, 2023

Hi,

I have two v1.4 runs with the following assertion failing:

>>> file: ont_resolved_graph.gfa.err
>>> ont resolve error
resolve k=8423, extended 1 nodes into 2 nodes
resolve hairpin >utig1-11098
Traceback (most recent call last):
File "[...]/lib/verkko/scripts/resolve_triplets_kmerify.py", line 1031, in <module>
resolve(node_lens, edge_overlaps, node_seqs, edges, paths_crossing, coverage, min_allowed_coverage, removable_nodes)
File "[...]/lib/verkko/scripts/resolve_triplets_kmerify.py", line 744, in resolve
assert len(resolved) == 0
AssertionError

I can share the Verkko run directory for debugging purposes, but only via Globus (push or pull).

Best,
Peter

@ptrebert
Copy link
Author

ptrebert commented Jul 4, 2023

actually, 3 failed runs here; I am transferring subfolders 2- and 4- to the T2T share

@skoren
Copy link
Member

skoren commented Jul 4, 2023

@maickrau could you take a look at these uploads. It seems when we have a hairpin w/no alignments or no resolution via alignments it will cause this failure.

@maickrau
Copy link
Collaborator

maickrau commented Jul 6, 2023

This should be fixed in 4f6a54e, the ont multiplex resolution didn't properly handle the case where the node is a hairpin disconnected from everything. Now it leaves them unresolved because they're probably spurious nodes, at least in the first case it was.

@ptrebert
Copy link
Author

ptrebert commented Jul 6, 2023

Surprisingly, ignoring the problem has fixed it ;-)
I copied the changed script into my Verkko installation as before, and the three runs now completed successfully. Thanks.

@ptrebert
Copy link
Author

ptrebert commented Jul 6, 2023

... would be nice to see a Verkko bugfix release nevertheless, of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants