-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Awesome 5 expander icons do not change when clicked. #871
Comments
My fix for this cause a new problem and I was hoping you had an idea how to fix it. In ext-glyph, I changed all occurrences of in setIcon, I added a call for a function specifically for handling FA5 in script mode:
and my FA5 script mode handler:
This all works except for the event handlers. Any ideas on how I should approach this? |
Could you post the code (jsFiddle, CodePen, ...) of what you tried? |
I made to different versions. The first version is what happens when FancyTree is used unedited but the Font Awesome 5 in script mode is used: https://jsfiddle.net/bindrid/504Lxerd/ This version has the jquery.fancytree.glyph.js inline and edited to handle a callback, and the specialized function for SVG-FA5. I put SGS by each change I made. This is what the Pull request was about until I closed it because of having to click twice on the tree to get the expanders to work after changing focus. |
Please have a look at the demo example here: This approach seems to work, and should be more performant and efficient as well, because the SVG conversion is only done per icon type (not per icon occurrence). |
I am having some of the same issues with your example. My web site has to work with IE 11, Edge and Chrome. It works better in Chrome but I still have to put focus back on the tree (first click) then click on the arrow (second click) before something happens. That does not happen with other, non-svg, trees |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Creating a new issue for the click-problem |
The click problem is followed-up here: #1033 |
I am using Font Awesome 5 in Script mode ( http://fontawesome.com/get-started/svg-with-js ).
In doing so, the script replaces the span node with a SVG node so I end up with HTML that looks like:
In jquery.fancytree.glyph.js nodeRenderStatus function reads:
Since the span is converted to SVG, the node is never found so its never updated.
The text was updated successfully, but these errors were encountered: