Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): Remove RGN records #354

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

orangejulius
Copy link
Member

These records seem to correspond to large, non-administrative, regions such as 'Northern Europe' and 'Southern California'. They feel very subjective and don't map well into administrative hierarchies, often coming up in unexpected search results.

There are only about 2200 and after a brief skim it looks safe to remove them all.

Fixes #70

These records seem to correspond to large, non-administrative, regions
such as 'Northern Europe' and 'Southern California'. They feel very
subjective and don't map well into administrative hierarchies, often
coming up in unexpected search results.

There are only about 2200 and after a brief skim it looks safe to remove
them all.

Fixes #70
@Joxit
Copy link
Member

Joxit commented Feb 18, 2019

LGTM

@missinglink
Copy link
Member

missinglink commented Feb 19, 2019

Sounds good, merging.

@missinglink missinglink merged commit 1401fd0 into master Feb 19, 2019
@missinglink missinglink deleted the filter-out-rgn-records branch February 19, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants