From 327ca1f184fc37efd8edd91553745fdc34bd8c78 Mon Sep 17 00:00:00 2001 From: Ian Wagner Date: Tue, 14 Nov 2023 18:32:32 +0900 Subject: [PATCH 1/4] Improve contribution docs; fix AndroidManifest.xml --- CONTRIBUTING.md | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ff4b69508..ab2d282ea 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,13 +4,20 @@ If you have a usage question pertaining to the Maplibre Navigation SDK for Andro If you want to contribute code: -1. Please familiarize yourself with the [install process](https://www.mapbox.com/android-docs/navigation/overview/#install-the-navigation-sdk). +1. Please familiarize yourself with the [install process](README.md). -2. Ensure that existing [pull requests](https://github.com/mapbox/mapbox-navigation-android/pulls) and [issues](https://github.com/mapbox/mapbox-navigation-android/issues) don’t already cover your contribution or question. +2. Ensure that existing [pull requests](https://github.com/maplibre/maplibre-navigation-android/pulls) and [issues](https://github.com/maplibre/maplibre-navigation-android/issues) don’t already cover your contribution or question. 3. Pull requests are gladly accepted. If there are any changes that developers should be aware of, please update the [change log](CHANGELOG.md) -4. Mapbox uses checkstyle to enforce good Java code standards, Make sure to read the [wiki entry](https://github.com/mapbox/mapbox-navigation-android/wiki/Setting-up-Mapbox-checkstyle) and setup. CI will fail if your PR contains any mistakes. +4. ~~We use checkstyle to enforce good coding standards. CI will fail if your PR contains any issues.~~ Lints are currently disabled; PRs welcome to improve the situation. Unit tests still run though! + +## Getting started building + +You can check out the repo and build locally using Android Studio or the gradle wrapper CLI, +just as with any other Kotlin/Java project. +Do note however that currently the lints fail, so you should run build excluding lints. +For example: `./gradlew build -x lint`. ## Adding or updating a localization From 8ec5c2b748a7109fd8a67050add205aa3075abc8 Mon Sep 17 00:00:00 2001 From: Ian Wagner Date: Tue, 14 Nov 2023 18:33:19 +0900 Subject: [PATCH 2/4] Fixes to libandroid-navigation/src/main/AndroidManifest.xml --- libandroid-navigation/src/main/AndroidManifest.xml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libandroid-navigation/src/main/AndroidManifest.xml b/libandroid-navigation/src/main/AndroidManifest.xml index f7631a2c8..495849579 100644 --- a/libandroid-navigation/src/main/AndroidManifest.xml +++ b/libandroid-navigation/src/main/AndroidManifest.xml @@ -4,19 +4,12 @@ + - - - From 6d5aa4c1ca766d3329e0af9e9bcc91ff52f4608b Mon Sep 17 00:00:00 2001 From: Ian Wagner Date: Tue, 14 Nov 2023 18:59:36 +0900 Subject: [PATCH 3/4] Update CHANGELOG; clean up translation and code of conduct --- CHANGELOG.md | 3 +++ CONTRIBUTING.md | 20 ++------------------ 2 files changed, 5 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e23af47c..8857763d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,9 @@ Maplibre welcomes participation and contributions from everyone. ### unreleased +- Android manifest cleanup for `libnavigation-android` + - Explicitly add `android.permission.ACCESS_NETWORK_STATE`, as this is needed for `com.mapbox.services.android.core.connectivity.ConnectivityReceiver` + - Remove Mapbox telemetry provider references (the references to code have already been removed) ### v3.0.0 - November 5, 2023 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ab2d282ea..9ce115a66 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,24 +19,8 @@ just as with any other Kotlin/Java project. Do note however that currently the lints fail, so you should run build excluding lints. For example: `./gradlew build -x lint`. -## Adding or updating a localization - -The Maplibre Navigation SDK for Android features several translations contributed through [Transifex](https://www.transifex.com/mapbox/mapbox-navigation-sdk-for-android/). If your language already has a translation, feel free to complete or proofread it. Otherwise, please [request your language](https://www.transifex.com/mapbox/mapbox-navigation-sdk-for-android/) so you can start translating. Note that we’re primarily interested in languages that Android supports as system languages. - -While you’re there, please consider also translating the following related projects: - -* [OSRM Text Instructions](https://www.transifex.com/project-osrm/osrm-text-instructions/), which the Mapbox Directions API uses to generate textual and verbal turn instructions ([instructions](https://github.com/Project-OSRM/osrm-text-instructions/blob/master/CONTRIBUTING.md#adding-or-updating-a-localization)) -* [Mapbox Navigation SDK for iOS](https://www.transifex.com/mapbox/mapbox-navigation-ios/), the analogous library for iOS applications ([instructions](https://github.com/mapbox/mapbox-navigation-ios/blob/master/CONTRIBUTING.md#adding-or-updating-a-localization)) -* [Mapbox Maps SDK for Android](https://www.transifex.com/mapbox/mapbox-gl-native/), which is responsible for the map view and minor UI elements such as the Mapbox Telemetry permissions dialog - -Once you’ve finished translating the Android navigation SDK into a new language in Transifex, open an issue in this repository asking to pull in your localization. Or do it yourself: - -1. _(First time only.)_ Download the [`tx` command line tool](https://docs.transifex.com/client/installing-the-client) and [configure your .transifexrc](https://docs.transifex.com/client/client-configuration). -1. Run `tx pull -a` to fetch translations from Transifex. You can restrict the operation to just the new language using `tx pull -l xyz`, where _xyz_ is the language code. -1. Commit any new files that were added and open a pull request with your changes. - # Code of conduct -Everyone is invited to participate in Mapbox’s open source projects and public discussions: we want to create a welcoming and friendly environment. Harassment of participants or other unethical and unprofessional behavior will not be tolerated in our spaces. The [Contributor Covenant](http://contributor-covenant.org) applies to all projects under the Mapbox organization and we ask that you please read [the full text](http://contributor-covenant.org/version/1/2/0/). +Everyone is invited to participate in MapLibre’s open source projects and public discussions: we want to create a welcoming and friendly environment. Harassment of participants or other unethical and unprofessional behavior will not be tolerated in our spaces. The [Contributor Covenant](http://contributor-covenant.org) applies to all projects under the Mapbox organization and we ask that you please read [the full text](http://contributor-covenant.org/version/1/2/0/). -You can learn more about our open source philosophy on [mapbox.com](https://www.mapbox.com/about/open/). +You can learn more about MapLibre at [maplibre.org](https://maplibre.org/). From 6a24e83a22524b1b59ca40666e9864a2c41fdb02 Mon Sep 17 00:00:00 2001 From: Ian Wagner Date: Tue, 14 Nov 2023 20:54:29 +0900 Subject: [PATCH 4/4] Remove xmlns:tools --- libandroid-navigation/src/main/AndroidManifest.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libandroid-navigation/src/main/AndroidManifest.xml b/libandroid-navigation/src/main/AndroidManifest.xml index 495849579..31b8d5dbf 100644 --- a/libandroid-navigation/src/main/AndroidManifest.xml +++ b/libandroid-navigation/src/main/AndroidManifest.xml @@ -1,6 +1,5 @@ + package="com.mapbox.services.android.navigation">