Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility] Attribution container should not have role="list" (or should have listitem children) #358

Closed
Malvoz opened this issue Sep 18, 2021 · 2 comments
Labels

Comments

@Malvoz
Copy link
Contributor

Malvoz commented Sep 18, 2021

this._innerContainer.setAttribute('role', 'list');

The attribution links should either be children of list items (role="listitem") or role="list" should be removed.

See motivation in https://dequeuniversity.com/rules/axe/4.2/list?application=RuleDescription (describes <ul> and <li> requirements, the same is applicable to the equivalent ARIA roles list and listitem).


(The same issue was also reported with MapBox: mapbox/mapbox-gl-js#11033.)

@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Mar 18, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant