deselectAnnotation and annotationsPopUpEnabled #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
suggested changes
Sep 20, 2016
| BOOL _attributionButton; | ||
| BOOL _logo; | ||
| BOOL _compass; | ||
| UIEdgeInsets _contentInset; | ||
| MGLAnnotationVerticalAlignment _userLocationVerticalAlignment; | ||
|
|
||
| BOOL _annotationsPopUpEnabled; |
There was a problem hiding this comment.
Make this a property so you don't need to implement the setter yourself.
| _selectedAnnotation = nil; | ||
| return; | ||
| } | ||
| _selectedAnnotation = annotation; |
There was a problem hiding this comment.
MGLMapView has a selectedAnnotations property for this.
|
Tested this is working on iOS and Android. Merging. |
|
Thank you so much, @dapetcu21. Any idea when this package will get updated in the npm registry? |
|
@bsudekum should have access to npm. Meanwhile you can |
irvingchenn
pushed a commit
to studyroz/react-native-mapbox-gl
that referenced
this pull request
Jun 9, 2020
…ltilesource Fix missing rctmgltilesource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #386. Will test tomorrow to see if everything's ok, then merge.