Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--module flag output module instead of self things #97

Closed
gertcuykens opened this issue Mar 19, 2019 · 1 comment · Fixed by #134
Closed

--module flag output module instead of self things #97

gertcuykens opened this issue Mar 19, 2019 · 1 comment · Fixed by #134
Labels
enhancement

Comments

@gertcuykens
Copy link

gertcuykens commented Mar 19, 2019 •
edited
Loading

Can we have a ES module versionimport pbf from 'https://unpkg.com/pbf@3.2.0/dist/pbf.mjs?module' please and a proto compiler --module flag that can output a module instead of a self thing. Life is to short to wait for a stable nodejs mjs release :)

Was hoping a bit of CI magic can generate a extra dist mjs automatically

Thanks
@gertcuykens gertcuykens changed the title import {pbf} from 'https://unpkg.com/mapbox/pbf?module' --browser flag output module instead of self things Mar 19, 2019
@gertcuykens gertcuykens changed the title --browser flag output module instead of self things --module flag output module instead of self things Mar 19, 2019
@mourner
Copy link
Member

mourner commented Mar 19, 2019

Yes, definitely in the plans!

@yannickcr yannickcr mentioned this issue Jul 22, 2020
Closed
@mourner mourner mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v4: modernize (ES & ESM), overhaul code generation mapbox/pbf
2 participants
@mourner @gertcuykens