Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is your library CSP friendly? (not using any unsafe eval expression)? #130

Closed
yvele opened this issue May 23, 2022 · 4 comments
Closed

Is your library CSP friendly? (not using any unsafe eval expression)? #130

yvele opened this issue May 23, 2022 · 4 comments
Labels

Comments

@yvele
Copy link

yvele commented May 23, 2022

When making a browser application, most of us are dealing with strict CSP (Content-Security-Policy) that disallow making use of unsafe-eval expressions.

I'm trying to switch from protobufjs to another library that is CSP friendly.
I can't see anything CSP related in your documentation. Can you please add a CSP paragraph where you explain that the library make uses (or NOT🤞 ) of unsafe-eval expression? And what CSP are required?

See also CSP issues that developers have with protobuf.js:

@mourner
Copy link
Member

mourner commented May 23, 2022

There should be no CSP issues with pbf — it doesn't use any code generation techniques that would need eval-like expressions. No special CSP rules are required to use it.

@yvele
Copy link
Author

yvele commented May 23, 2022

Thank you so much @mourner this is really reassuring, I will give pbf a try.
What about adding a little CSP paragraph in the doc about that? Because many people are struggling with CSP and seing that being CSP friendly is part of the library fundamental is a big plus 👍

@yvele
Copy link
Author

yvele commented May 23, 2022

Thank you @mourner I'm using pbf and it works like a charm with strict CSP.
Awesome lightweight low level library 👏

@yvele yvele closed this as completed May 23, 2022
@aberrier
Copy link

Hello @yvele, I followed your comments on Github as I've came across the same issue of using protobufjs with CSP constraints.
Thank you for your feedback on pbf that will clearly makes me and any future developers win precious time on finding CSP-friendly alternatives to protobufjs ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants