Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data team peer review 7/25-7/29 #216

Closed
karitotp opened this issue Aug 2, 2016 · 37 comments
Closed

Data team peer review 7/25-7/29 #216

karitotp opened this issue Aug 2, 2016 · 37 comments

Comments

@karitotp
Copy link

karitotp commented Aug 2, 2016

Last peer review ticket: #214

Mapping projects to be reviewed:

  1. To-Fix
  2. Turn restriction in Canada

Instructions

  • Download .osm files for last week.
  • Extract the tar file and select any OSM file of the team member.
  • Each team member will have an .osm file of edits for the last seven days. For example: latest-andygol.osm. Select any .osm file and open the data in JOSM.
  • If you don't find any osm file of a particular team member, then it means that user has not edited during the week.
  • Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
  • Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

  • Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
  • To get an OSM link to the object, click Cmd + Shift + H.
  • Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:
username
changeset link - issue to fix
  • @krishnanammala @chtnha or @karitotp will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
  • Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@poornibadrinath

Incorrect name of highway , the layer TIGER says other name

https://www.openstreetmap.org/way/18162230/history

Improve this highway

https://www.openstreetmap.org/way/435093026/history

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@pratikyadav

Line does not match the bing aerial imagery

https://www.openstreetmap.org/way/150850618

Add name of road using New & Misaligned TIGER Roads (2015)

https://www.openstreetmap.org/way/434312883

Add multipolygon

https://www.openstreetmap.org/way/435091342

Improve the aligning of the water

https://www.openstreetmap.org/way/368435592

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@ediyes

Add bridge on this road

https://www.openstreetmap.org/way/48181094/history

Improve the end of this street based on imagery

https://www.openstreetmap.org/way/21629407/history

Fix self intersecting highways

https://www.openstreetmap.org/way/435401065/history

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@samely

Combine the bridges

https://www.openstreetmap.org/way/105851792/history

Doesn't work if satellite imagery isn't clear

https://www.openstreetmap.org/way/357841615/history

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/way/229925642/history

@karitotp
Copy link
Author

karitotp commented Aug 3, 2016

@dannykath
Copy link

@poornibadrinath
Copy link
Contributor

Thank you for the feedback team!

Improved this highway
https://www.openstreetmap.org/way/435093026/history#map=18/41.10391/-73.92534

Name of the highway
https://www.openstreetmap.org/way/18162230/history, even though tiger data says it's Poplar street, it's actually Poplar avenue. This change was made based on local knowledge and map feedback, the user had commented saying it was avenue. Confirmed it by another person by adding a note and also reading about the difference between a street and an avenue. Since this road runs north to south, it is technically an avenue.

@planemad
Copy link
Contributor

planemad commented Aug 4, 2016

@ediyes
Copy link

ediyes commented Aug 4, 2016

Thank for the feedback!!

Add bridge on this road

https://www.openstreetmap.org/changeset/41236731

Improve the end of this street based on imagery

https://www.openstreetmap.org/way/21629407/history

Fix self intersecting highways

https://www.openstreetmap.org/way/435401065/history - Not an error

@samely
Copy link

samely commented Aug 4, 2016

Thanks for the feedback team!!!

Combine the bridges

https://www.openstreetmap.org/changeset/41239612

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/changeset/41239671

@karitotp
Copy link
Author

karitotp commented Aug 4, 2016

Thanks for the review team!!

Align highway

@pratikyadav
Copy link
Contributor

Thanks 🙏

Line does not match the bing aerial imagery https://www.openstreetmap.org/way/150850618

❎ Based on history, this way was not added by me but shows up in my edits as I added a note by joining nearby way. The way looks aligned with bing and mapbox imagery. The only problem I spotted was 2 highway-water intersecting ways which I fixed here https://www.openstreetmap.org/changeset/41319685

Add name of road using New & Misaligned TIGER Roads (2015) https://www.openstreetmap.org/way/434312883

✅ Done https://www.openstreetmap.org/changeset/41319768

Add multipolygon https://www.openstreetmap.org/way/435091342

❎ Highly doubt this is multipolygon. Per http://wiki.openstreetmap.org/wiki/Tag:sport%3Drunning looks like sport=running and leisure=track are the tag to be used here.

Improve the aligning of the water https://www.openstreetmap.org/way/368435592

https://www.openstreetmap.org/changeset/41319950

@oini
Copy link

oini commented Aug 8, 2016

Thanks for the feedbacks!

Untagged way

https://www.openstreetmap.org/way/434315898

http://www.openstreetmap.org/changeset/41319777

Improve the aligning of the highway

https://www.openstreetmap.org/way/6775551 - check around
https://www.openstreetmap.org/way/434315939

❎ In response to a map-feedback that stated:

Going northbound the road stops here at a house. It does not continue either left or right.

So all I did here was split an existing road into 3 parts and delete the part that did not exists. All the roads here have been added via Tiger Import and thus none of them align with satellite imagery like most other parts in the US and would require a separate task to fix them. Also, while working on map-feedbacks, we concentrate on fixing just the issue reported by the user. Nonetheless, I have aligned the 2 roads with the imagery:

@jothirnadh
Copy link

jothirnadh commented Aug 8, 2016

Thanks for the review @karitotp

Give form to the road :

Decided not to fix blow errors because this data is added by Facebook and they are going to revert their changes.

Add layer=1

https://www.openstreetmap.org/way/435093463/history

@luiswalter
Copy link

thanks Team!

oneway=-1 is not recommended

https://www.openstreetmap.org/way/435358376#map=19/42.00944/-87.89394
https://www.openstreetmap.org/way/435345689#map=19/42.07960/-87.76118
https://www.openstreetmap.org/way/382386717#map=19/42.07955/-87.75570 No error
https://www.openstreetmap.org/way/109699060#map=19/42.03349/-87.75139
https://www.openstreetmap.org/way/435336150#map=19/42.03349/-87.74758
https://www.openstreetmap.org/way/435336165#map=19/42.03353/-87.75474
https://www.openstreetmap.org/way/435336205#map=19/42.03359/-87.75722
https://www.openstreetmap.org/way/435331876#map=19/42.06248/-87.74814
https://www.openstreetmap.org/way/435331864#map=19/42.06251/-87.75463
https://www.openstreetmap.org/way/435331868#map=19/42.06253/-87.75292
https://www.openstreetmap.org/way/435331872#map=19/42.06243/-87.74934
https://www.openstreetmap.org/way/435331870#map=19/42.06245/-87.75164
https://www.openstreetmap.org/way/435385338#map=19/42.05081/-87.68179
https://www.openstreetmap.org/way/313309913#map=19/42.04084/-87.74785

Incorrect number of turn lanes

https://www.openstreetmap.org/way/435328866#map=19/41.88805/-87.86346 No error
https://www.openstreetmap.org/way/435327212#map=19/41.90418/-87.93986
https://www.openstreetmap.org/way/435346227 No error

Wrong turn lanes

https://www.openstreetmap.org/way/435327231#map=19/41.91315/-87.93977 No error
https://www.openstreetmap.org/way/435327812#map=19/41.91721/-87.94024 no error
https://www.openstreetmap.org/way/435394498#map=19/42.13838/-87.85773

You need to add signaling of turn lane

https://www.openstreetmap.org/way/435327225 No error

The image doesn't show signal turn lane in all way

https://www.openstreetmap.org/way/435336188

@unsungNovelty
Copy link
Contributor

unsungNovelty commented Aug 9, 2016

Thanks a lot for the review and feedback team. Below are my fixes and comments:

Fixes:

  • Way untagged

https://www.openstreetmap.org/way/435022637 - Fix

Comments:

  • Remove turn lanes unnecessary

https://www.openstreetmap.org/way/312343576 - No fix needed as this is a legitimate way of tagging turn lanes.
https://www.openstreetmap.org/way/312343574 - No fix needed as this is a legitimate way of tagging turn lanes.

@maanyaumashaanker
Copy link

@krishnanammala
Copy link
Contributor

Thanks everyone for fixing the issues. Closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests