-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data team peer review 7/25-7/29 #216
Comments
Incorrect name of highway , the layer TIGER says other namehttps://www.openstreetmap.org/way/18162230/history Improve this highway |
Untagged wayhttps://www.openstreetmap.org/way/434315898 Improve the aligning of the highwayhttps://www.openstreetmap.org/way/6775551 - check around |
@chtnha Improve the aligning of the highwayhttps://www.openstreetmap.org/way/260744199 Add bridgehttps://www.openstreetmap.org/node/1175774443 Crossing waterway with highway |
Fix
|
Add missing turn laneshttps://www.openstreetmap.org/way/110570257 Incorrect starting of the turn laneshttps://www.openstreetmap.org/way/435091067 Incorrect number of laneshttps://www.openstreetmap.org/way/435091072 in forward |
Line does not match the bing aerial imageryhttps://www.openstreetmap.org/way/150850618 Add name of road using New & Misaligned TIGER Roads (2015)https://www.openstreetmap.org/way/434312883 Add multipolygonhttps://www.openstreetmap.org/way/435091342 Improve the aligning of the water |
Add bridge on this roadhttps://www.openstreetmap.org/way/48181094/history Improve the end of this street based on imageryhttps://www.openstreetmap.org/way/21629407/history Fix self intersecting highways |
@nikhilprabhakar Remove turn lanes unnecessaryhttps://www.openstreetmap.org/way/312343576 Way untagged |
Combine the bridgeshttps://www.openstreetmap.org/way/105851792/history Doesn't work if satellite imagery isn't clearhttps://www.openstreetmap.org/way/357841615/history Incorrect starting or ending of the tunnel |
Crossing Highwayhttps://www.openstreetmap.org/way/434887973 Need to add
|
Align highway |
Thanks for the feedback team!!! Split wayshttps://www.openstreetmap.org/changeset/41227016 No satellite imagery viewhttps://www.openstreetmap.org/way/412759338/history Missing crossing wayshttps://www.openstreetmap.org/node/352735558/history - not error Improve this wayhttps://www.openstreetmap.org/changeset/41227083 Fix number of laneshttps://www.openstreetmap.org/changeset/41202271 Split the way and fix turn laneshttps://www.openstreetmap.org/changeset/41227242 Incorrect end of turn lane |
Thanks for your review team! Fix
|
Hey @mapbox/peru-office, Thanks for the feedback. Here are my fixes. Aligned the roads ✅*https://www.openstreetmap.org/way/260819519/history
Add bridge ✅https://www.openstreetmap.org/way/435597254/history Crossing waterway with highway ✅ |
Thank you for the feedback team! Improved this highway Name of the highway |
@karitotp thank you. Fixes:
https://www.openstreetmap.org/changeset/41229474
https://www.openstreetmap.org/changeset/41230012
Wontfix, no building label here
Wontfix, needs field survey
https://www.openstreetmap.org/changeset/41233482
https://www.openstreetmap.org/changeset/41233584 |
Thank for the feedback!! Add bridge on this roadhttps://www.openstreetmap.org/changeset/41236731 Improve the end of this street based on imageryhttps://www.openstreetmap.org/way/21629407/history Fix self intersecting highwayshttps://www.openstreetmap.org/way/435401065/history - Not an error |
Thanks for the feedback team!!! Combine the bridgeshttps://www.openstreetmap.org/changeset/41239612 Incorrect starting or ending of the tunnel |
Thanks for the review team!!
|
Thanks for the feedback team
https://www.openstreetmap.org/way/435322356/history It isn't mistake |
Thanks 🙏
❎ Based on history, this way was not added by me but shows up in my edits as I added a note by joining nearby way. The way looks aligned with bing and mapbox imagery. The only problem I spotted was 2 highway-water intersecting ways which I fixed here https://www.openstreetmap.org/changeset/41319685
✅ Done https://www.openstreetmap.org/changeset/41319768
❎ Highly doubt this is multipolygon. Per http://wiki.openstreetmap.org/wiki/Tag:sport%3Drunning looks like
|
Thanks for the feedbacks!
✅ http://www.openstreetmap.org/changeset/41319777
❎ In response to a map-feedback that stated:
So all I did here was split an existing road into 3 parts and delete the part that did not exists. All the roads here have been added via Tiger Import and thus none of them align with satellite imagery like most other parts in the US and would require a separate task to fix them. Also, while working on map-feedbacks, we concentrate on fixing just the issue reported by the user. Nonetheless, I have aligned the 2 roads with the imagery: |
Thanks for the review @karitotp Give form to the road :Decided not to fix blow errors because this data is added by Facebook and they are going to revert their changes.
Add layer=1 |
Thanks a lot for the review and feedback team. Below are my fixes and comments:Fixes:
https://www.openstreetmap.org/way/435022637 - Fix Comments:
https://www.openstreetmap.org/way/312343576 - No fix needed as this is a legitimate way of tagging turn lanes. |
Thank you very much for reviewing the edits Missing turn laneshttps://www.openstreetmap.org/changeset/41340044 Incorrect starting of turn laneshttps://www.openstreetmap.org/changeset/41340397 Incorrect number of laneshttps://www.openstreetmap.org/way/435091072 in forward (looks right) |
Thanks! Here are my changes.
https://www.openstreetmap.org/changeset/41362158
Won't fix, this is a building part and needs local to confirm.
|
Thanks everyone for fixing the issues. Closing here. |
Last peer review ticket: #214
Mapping projects to be reviewed:
Instructions
.osm
files for last week.latest-andygol.osm
. Select any.osm
file and open the data in JOSM.3
to zoom.Cmd + F
to see only the user's edits, e.g.user:andygol
.Ctrl + H
), the changeset comment will describe what specific project the user was working on.Cmd + Shift + H
.For clarifications, discuss with the @mapbox/team-data in this ticket.
The text was updated successfully, but these errors were encountered: