Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom image (shield or badge) to street name #637

Closed
Sealos opened this issue Sep 21, 2017 · 10 comments
Closed

Adding custom image (shield or badge) to street name #637

Sealos opened this issue Sep 21, 2017 · 10 comments
Labels
archived Archived issue.

Comments

@Sealos
Copy link
Contributor

Sealos commented Sep 21, 2017

On the current NavigationViewController, the European E4 route is currently displayed as E 4.26.

The badge in question is:
e4

img_0007

Two possible approaches

  1. Change the text before its displayed
  2. Provide a delegate function to return an optional image for a given street
@frederoni
Copy link
Contributor

Previous discussions about expanding shield coverage beyond the US (#334) and inlining shields (#365)

@Sealos
Copy link
Contributor Author

Sealos commented Sep 21, 2017

@frederoni Thanks!, in the meantime, is it possible to change the text to remove that the ".26"?

@1ec5
Copy link
Contributor

1ec5 commented Sep 21, 2017

The turn banner is saying to continue onto this way in OpenStreetMap, which is tagged ref=E 4.26. If I understand correctly, this is how link roads are numbered in some countries. Is that tag inconsistent with the signage in this area?

@Sealos
Copy link
Contributor Author

Sealos commented Sep 22, 2017

The .26 is not shown, only the E4 (spacing changes, some roads add space, others don't) is shown. For example:
image
image

In some cases, you can also see an "N" or "S" depending on the direction of the road.
image
image

@frederoni
Copy link
Contributor

frederoni commented Sep 22, 2017

Link numbers on link roads are never shown or used externally but seem to be used frequently at Trafikverket which makes me hesitative whether this issue is a data issue or client issue. Either way, we should expose a way to modify the instruction. I'd suggest a VisualInstructionFormatter property on NavigationViewController and the formatter should be refactored to use NSAttributedString and support for asynchronous as well as synchronous updates to fully support inlining local and remote shield images.

@davols
Copy link

davols commented Sep 22, 2017

Been told they are officially/technically the number of the link road at nvdb/trafikverket. So wouldn't that make it a client issue? The link number is never used on signage or "real life".

Or perhaps an issue towards osrm-text-instructions or osrm-backend for rewriting those tags? Since the link number exists on the web and android as well.

Edit:
I've started a thread over at talk-se. I did phrase myself incorrectly earlier in this comment, it's not the name of the road. It's the number (and official number includes the linknumer which isn't used on signs). Could be confusing.

@1ec5
Copy link
Contributor

1ec5 commented Sep 23, 2017

The link number is never used on signage or "real life".

The prevailing practice in OpenStreetMap is to reserve the ref tag for signposted route numbers. Numbers that aren’t signposted prominently enough for wayfinding, such as government inventory numbers, should go in official_ref, unsigned_ref, or ad-hoc tags like ref:penndot (using the name of the roads agency).

It’d wouldn’t be practical to special-case inventory numbers in this library, especially since they aren’t easily identifiable without more context. For example, some U.S. counties and townships prominently post decimal route numbers, while the U.S. state of Pennsylvania has a system of virtually unsignposted “quadrant routes” consisting of four-digit numbers. Yet OSRM doesn’t even provide this library with enough information to know whether “E” means a European route, an express road in Colorado, or something else. #334 would give the SDK more context, but even then, list of patterns of unsignposted routes would be difficult to maintain even in OSRM-backend.

At the moment, there are 1,624 ways tagged with what looks like a link E road number. Ultimately, I think retagging them would be appropriate if these numbers are always unsignposted. The first step would be contacting the talk-se mailing list, but I don’t know a lick of Swedish. 😅

@1ec5
Copy link
Contributor

1ec5 commented Sep 23, 2017

In some cases, you can also see an "N" or "S" depending on the direction of the road.

This is good to know. Both the Mapbox Directions API and Navigation SDK currently rely on a tagging scheme that’s prevalent in the U.S. but could conceivably be used in Europe as well: link roads leading to motorways are tagged e.g. destination=SR 123 North. Unfortunately it’s an unstructured format, as opposed to destination_sign relations, but it’s the best we can do until Project-OSRM/osrm-backend#482 and related functionality is fully implemented in the router.

@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived issue. label Jul 26, 2020
@stale
Copy link

stale bot commented Aug 9, 2020

Stale.

@stale stale bot closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived Archived issue.
Projects
None yet
Development

No branches or pull requests

5 participants