From 3c2054e6b8c9d76714d50baf173f8cf7a117b7a0 Mon Sep 17 00:00:00 2001
From: Langston Smith <langston.smith@mapbox.com>
Date: Wed, 3 Jul 2019 08:30:51 -0700
Subject: [PATCH] tweaks after @lukaspaczos review

---
 Makefile                           | 8 --------
 README.md                          | 2 +-
 build.gradle                       | 1 -
 circle.yml                         | 8 +++++++-
 services-core/gradle.properties    | 2 --
 services-geojson/gradle.properties | 2 --
 services-turf/gradle.properties    | 2 --
 services/gradle.properties         | 2 --
 8 files changed, 8 insertions(+), 19 deletions(-)

diff --git a/Makefile b/Makefile
index ce51ddb1d..9d566de72 100644
--- a/Makefile
+++ b/Makefile
@@ -39,14 +39,6 @@ publish-snapshot:
 	export IS_LOCAL_DEVELOPMENT=false; ./gradlew :services:artifactoryPublish ; \
 	export IS_LOCAL_DEVELOPMENT=false; ./gradlew :services-turf:artifactoryPublish ; \
 
-
-publish-local:
-	# This publishes to ~/.m2/repository/com/mapbox/mapboxsdk
-	export IS_LOCAL_DEVELOPMENT=true; ./gradlew :services-core: bintrayUpload ; \
-    export IS_LOCAL_DEVELOPMENT=true; ./gradlew :services-geojson: bintrayUpload ; \
-    export IS_LOCAL_DEVELOPMENT=true; ./gradlew :services: bintrayUpload ; \
-    export IS_LOCAL_DEVELOPMENT=true; ./gradlew :services-turf: bintrayUpload ; \
-
 graphs:
 	./gradlew :services-core:generateDependencyGraphMapboxLibraries
 	./gradlew :services-geojson:generateDependencyGraphMapboxLibraries
diff --git a/README.md b/README.md
index 446dd9479..71c2a34e1 100644
--- a/README.md
+++ b/README.md
@@ -41,7 +41,7 @@ If you want to test recent bugfixes or features that have not been packaged in a
 
 ```gradle
 repositories {
-    mavenCentral()
+    jcenter()
     maven { url 'https://oss.jfrog.org/artifactory/oss-snapshot-local/' }
 }
 
diff --git a/build.gradle b/build.gradle
index d43dd221d..22cb9b3d0 100644
--- a/build.gradle
+++ b/build.gradle
@@ -3,7 +3,6 @@ buildscript {
 
   repositories {
     maven { url 'https://plugins.gradle.org/m2' }
-    maven { url 'https://oss.jfrog.org/artifactory/oss-snapshot-local/' }
     google()
     mavenCentral()
     jcenter()
diff --git a/circle.yml b/circle.yml
index a78163d7f..7efeb14c8 100644
--- a/circle.yml
+++ b/circle.yml
@@ -64,13 +64,19 @@ jobs:
               BINTRAY_API_KEY=$BINTRAY_API_KEY
               GPG_PASSPHRASE=$GPG_PASSPHRASE"
             fi
+      - run:
+          name: Update version name
+          command: |
+            if [[ $CIRCLE_TAG == v* ]]; then
+              sed -i -e "s/^VERSION_NAME=.*/VERSION_NAME=${CIRCLE_TAG:9}/" gradle.properties
+            fi          
       - run:
           name: Build Java libraries
           command: make build-release
       - deploy:
           name: Publish Java libraries to Bintray
           command: |
-            if [[ $CIRCLE_BRANCH == master ]] || [[ $CIRCLE_BRANCH == release-* ]] || [[ $CIRCLE_TAG == android-v* ]]; then
+            if [[ $CIRCLE_BRANCH == master ]] || [[ $CIRCLE_TAG == android-v* ]]; then
               version=$(cat gradle.properties | grep "VERSION_NAME")
               if [[ $version != *"SNAPSHOT"* ]]; then
                 make publish-to-bintray
diff --git a/services-core/gradle.properties b/services-core/gradle.properties
index 8880a185e..9b085efb8 100644
--- a/services-core/gradle.properties
+++ b/services-core/gradle.properties
@@ -1,5 +1,3 @@
-VERSION_NAME=4.9.0-SNAPSHOT
 POM_ARTIFACT_ID=mapbox-sdk-core
-POM_NAME=Mapbox Services SDK
 POM_DESCRIPTION=Mapbox Services SDK (Core module)
 POM_PACKAGING=jar
\ No newline at end of file
diff --git a/services-geojson/gradle.properties b/services-geojson/gradle.properties
index a5cffa5cc..0841ace5b 100644
--- a/services-geojson/gradle.properties
+++ b/services-geojson/gradle.properties
@@ -1,5 +1,3 @@
-VERSION_NAME=4.9.0-SNAPSHOT
 POM_ARTIFACT_ID=mapbox-sdk-geojson
-POM_NAME=Mapbox Services SDK
 POM_DESCRIPTION=Mapbox Services SDK (GeoJSON support)
 POM_PACKAGING=jar
\ No newline at end of file
diff --git a/services-turf/gradle.properties b/services-turf/gradle.properties
index 855d84768..3c43d4c8a 100644
--- a/services-turf/gradle.properties
+++ b/services-turf/gradle.properties
@@ -1,5 +1,3 @@
-VERSION_NAME=4.9.0-SNAPSHOT
 POM_ARTIFACT_ID=mapbox-sdk-turf
-POM_NAME=Mapbox Services SDK
 POM_DESCRIPTION=Mapbox Services SDK (Turf support)
 POM_PACKAGING=jar
\ No newline at end of file
diff --git a/services/gradle.properties b/services/gradle.properties
index d0c475f34..bb4a6f61b 100644
--- a/services/gradle.properties
+++ b/services/gradle.properties
@@ -1,5 +1,3 @@
-VERSION_NAME=4.9.0-SNAPSHOT
 POM_ARTIFACT_ID=mapbox-sdk-services
-POM_NAME=Mapbox Services SDK
 POM_DESCRIPTION=Mapbox Services SDK (APIs)
 POM_PACKAGING=jar
\ No newline at end of file