You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
No matter what we use as the source for jazzy, we’re going to wind up with incorrect URLs (either the paths or the line numbers). Here’s a possible alternative:
Copy the examples to the original headers to be checked in.
Revert the changes to jazzy.yml and document.sh.
Keep the unit tests. Add a unit test that ensures the headers are in sync with the tests (by comparing the headers’ contents to the test file’s contents).
#7337 changed the
framework-root
configuration variable for jazzy from../darwin/src
to the hard-coded pathbuild/ios/pkg/dynamic/Mapbox.framework
. Now the “View Source on GitHub” links point to e.g. https://github.com/mapbox/mapbox-gl-native/tree/ios-v3.4.0-beta.6/build/ios/pkg/dynamic/Mapbox.framework/Headers/MGLShapeSource.h#L106 – with the right line numbers but a nonexistent path./cc @ericrwolfe
The text was updated successfully, but these errors were encountered: