Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Raw expression support #11158

Closed
tobrun opened this issue Feb 9, 2018 · 3 comments
Closed

Raw expression support #11158

tobrun opened this issue Feb 9, 2018 · 3 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@tobrun
Copy link
Member

tobrun commented Feb 9, 2018

Feedback from a user trying out expressions: It would have been nice being able to use raw expressions as used in the style-spec. This would allow for both using the current DSL approach in combination with approach taken in the style-spec.

eg.

iconImage(get("key"))

vs

iconImage("[\"get\", key]")
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 9, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Feb 9, 2018
@jfirebaugh
Copy link
Contributor

How would you distinguish a literal string value from an expression string?

@anandthakker
Copy link
Contributor

@tobrun what about adding a raw() function to the DSL?

iconImage(raw("[\"get\", key]"))

@1ec5
Copy link
Contributor

1ec5 commented Apr 30, 2018

This will significantly reduce the amount of work needed for nitaliano/react-native-mapbox-gl#1047, since the iOS map SDK already has something like this.

Note that a similar conversion would be needed for filters as well.

/cc @nitaliano

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants