Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks are broken by RemovePaintState benchmark #7927

Closed
andycalder opened this issue Feb 19, 2019 · 1 comment · Fixed by #7930
Closed

Benchmarks are broken by RemovePaintState benchmark #7927

andycalder opened this issue Feb 19, 2019 · 1 comment · Fixed by #7930

Comments

@andycalder
Copy link
Contributor

It appears that the "version" benchmarks have been broken since b01a5d3. The bug made it in to the v0.53.0 release so it's impossible to benchmark feature work against master or release. I have traced the problem to a bad export here (should be export default). The benchmark looks like it might be incomplete because there are three unused classes.

mapbox-gl-js version: master and v0.53.0

browser: All

Steps to Trigger Behavior

  1. Start the benchmarks server.
  2. Go to http://localhost:9966/bench/versions.

Expected Behavior

No error.

Actual Behavior

TypeError: RemovePaintState$1 is not a constructor.

@ryanhamley
Copy link
Contributor

Thanks for reporting this @andycalder. This is fixed now but the release branch will contain the bug until our next official release in a couple weeks. You can work around the release branch for the time being by changing https://github.com/mapbox/mapbox-gl-js/blob/master/bench/versions/index.html#L22 to .then(pkg => [ 'master'])). This will then run your current branch only against master and you shouldn't see any further errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants