Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fill-extrusion stroke style #4231

Closed
stevage opened this issue Feb 8, 2017 · 3 comments
Closed

Support fill-extrusion stroke style #4231

stevage opened this issue Feb 8, 2017 · 3 comments

Comments

@stevage
Copy link
Contributor

stevage commented Feb 8, 2017

It would be useful to be able to style the edges of fill-extrusions. (And possible, independently style the vertical edges versus the flat edges at the top and bottom).

Why? It's currently not possible to visually distinguish between two adjacent fill-extrusions. The main workaround is to give each of them a slightly different color (which means you can't really use color as an independent variable visualisation).

3d-vis-adjacent

A contrasting stroke colour could also be aesthetically preferable in some cases, and to help better perceive the 3D shape. For instance:

image

I'm not fussed whether the occluded edges are rendered or not.

@lbud
Copy link
Contributor

lbud commented Feb 8, 2017

@stevage this property was initially implemented but removed due to concerns about antialiasing, as well as the lesson we'd already learned regretting fill-outline-color: mapbox/mapbox-gl-style-spec#456 (comment), #3223 (comment). We do not intend to revive it. To distinguish between extrusions I'd suggest experimenting with adding more contrast between your basemap and fill-extrusions and/or playing with the light property.

@lbud lbud closed this as completed Feb 8, 2017
@stevage
Copy link
Contributor Author

stevage commented Feb 8, 2017

Ah, thanks. Dang. Seems like the kind of feature where for some use cases it would be worth someone forking the codebase to reinstate. That screenshot looks so sweet :/

@rowanwins
Copy link

Just dropping a note here that this is available in the ArcGIS JS API, eg this demo.

In my case I'd love to be able to render outlines to show the floors of a building and then apply symbology to each floor, for example looking at a building I can distinguish which floors have vacancy - this would have lots of potential in the real estate world for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants