Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.11 introduces a bug that causes misalignment of object and selection #12632

Closed
dealeros opened this issue Mar 29, 2023 · 3 comments · Fixed by #12633
Closed

v2.11 introduces a bug that causes misalignment of object and selection #12632

dealeros opened this issue Mar 29, 2023 · 3 comments · Fixed by #12633
Labels

Comments

@dealeros
Copy link

dealeros commented Mar 29, 2023

mapbox-gl-js version: v2.11

browser: Chrome

Steps to Trigger Behavior

Mouse hover on sphere

Link to Demonstration

v2.11 -> https://jsbin.com/ruxenuyazi/edit?html,output (incorrect behaviour)
v2.10 -> https://jsbin.com/moxayupeze/1/edit?html,output (correct behaviour)

Expected Behavior

When mouse hover on sphere it should be selected

Actual Behavior

Area of selection doesn't match object.

@stepankuzmin
Copy link
Contributor

Hi @dealeros,

What browser do you use? I couldn't reproduce it with the lastest versions of Chrome, Safari, and Firefox on macOS.

v2.11

Screenshot 2023-03-29 at 14 43 46

v2.10

Screenshot 2023-03-29 at 14 43 59

@dealeros
Copy link
Author

dealeros commented Mar 29, 2023

Hi @stepankuzmin!
Yes, in both versions box boundaries still appear. But please notice that in v2.11 it doesn't work on the whole surface of the sphere.

From default view please hover cursor on the highlighted area:

image

My Chrome version is 111.0.5563.111
But I can observe the same behaviour on FF.

Actually after opening this issue I found similar one here jscastro76/threebox#376

@stepankuzmin
Copy link
Contributor

stepankuzmin commented Mar 29, 2023

Yes, I can see now that hovering on the right-hand side is not highlighting the feature.
Caused by this commit ca2f99f in #12138

The Transform class isn't part of the public API, so it's a bit of an issue on threebox-plugin behalf to rely on that internal code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants