Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Geocoding example #17

Closed
1ec5 opened this issue May 10, 2016 · 4 comments
Closed

Geocoding example #17

1ec5 opened this issue May 10, 2016 · 4 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 10, 2016

There should be an example in which the user can long-press the map to drop a pin and see its address, geocoded using the Geocoding API via MapboxGeocoder.swift.

/ref #6
/cc @friedbunny @tmcw

@friedbunny
Copy link
Contributor

friedbunny commented May 11, 2016

How should external dependencies be presented to the user?

@1ec5
Copy link
Contributor Author

1ec5 commented May 11, 2016

It should be sufficient to link to the Mapbox*.swift projects’ READMEs. If those READMEs are lacking, please expand on anything that I’ve glossed over. I don’t think it’ll be so bad: once the user has installed our iOS SDK, these libraries can be installed using much the same workflows. (Granted, it’d be more of a leap for Fabric users – no jiggling briefcase animations this time.)

More broadly, we can consider expanding the /ios-sdk front page with dedicated sections for the Mapbox*.swift libraries, like what we’ve got on /android-sdk. But that suggests a rename from /ios-sdk to /ios, which is overkill for now.

@captainbarbosa captainbarbosa self-assigned this Jul 19, 2017
@captainbarbosa captainbarbosa removed their assignment Jan 2, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 13, 2018

More broadly, we can consider expanding the /ios-sdk front page with dedicated sections for the Mapbox*.swift libraries, like what we’ve got on /android-sdk.

/ios-sdk now covers all the SDKs. This project, meanwhile, already depends on the navigation SDK and thus MapboxDirections.swift, so a dependency on MapboxGeocoder.swift doesn’t sound so bad.

@captainbarbosa
Copy link
Contributor

/ios-sdk now covers all the SDKs.

It doesn't anymore 😁 and nav examples were moved to their own repo in #324. Because of this, I'm inclined to close this, and keeping examples in MapboxGeocoder.swift for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants