Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few edge cases with bad diagonals #123

Closed
mourner opened this issue Sep 18, 2019 · 1 comment · Fixed by #124
Closed

A few edge cases with bad diagonals #123

mourner opened this issue Sep 18, 2019 · 1 comment · Fixed by #124
Assignees
@mourner
Labels
bug

Comments

@mourner
Copy link
Member

mourner commented Sep 18, 2019

Following up after #120, here are remaining 4 failing test cases I'd like to solve: https://gist.github.com/mourner/59b29d4a62ab2864eaed1a7014f6eb0d

Seems like they are caused by bad diagonals in the splitEarcut routine, but will investigate further. cc @mrgreywater
@mourner mourner added the bug label Sep 18, 2019
@mourner mourner self-assigned this Sep 18, 2019
@mourner
Copy link
Member Author

mourner commented Sep 18, 2019

Almost there — one remaining, and will also close #110.

@mourner mourner mentioned this issue Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mourner mourner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bunch of rare edge cases mapbox/earcut
1 participant
@mourner