Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swift Package Manager #132

Closed
1ec5 opened this issue Jan 18, 2018 · 1 comment · Fixed by #209
Closed

Support Swift Package Manager #132

1ec5 opened this issue Jan 18, 2018 · 1 comment · Fixed by #209
Labels
build

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 18, 2018 •
edited
Loading

Add a Package.swift file so that Swift Package Manager can incorporate this library into a project.

/cc @frederoni @captainbarbosa
@1ec5 1ec5 added the build label Jan 18, 2018
@1ec5 1ec5 mentioned this issue Jun 5, 2019
Closed
@1ec5 1ec5 mentioned this issue Jul 29, 2019
Open
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 11, 2020

This is complicated by the fact that MBPlacemarkPrecision is currently declared and defined in Objective-C, and SPM also doesn’t support @objc. SPM doesn’t support mixed-language modules. The most expedient solution would be to reimplement MBPlacemarkPrecision in Swift (while keeping the Objective-C implementation for CocoaPods- and Carthage-based builds) and conditionalizing @objc on SWIFT_PACKAGE. Such workarounds would be unnecessary if we were to drop Objective-C support altogether, something we should do if SPM becomes the primary dependency manager for the Swift service libraries at some point.

/ref mapbox/mapbox-directions-swift#381 mapbox/mapbox-directions-swift#362

@1ec5 1ec5 mentioned this issue Nov 11, 2020
Merged
10 tasks
@1ec5 1ec5 closed this as completed in #209 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support installation via Swift Package Manager mapbox/MapboxGeocoder.swift
1 participant
@1ec5