Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations / Missing en_US translations #86

Open
DiabolicAngeL opened this issue Jul 16, 2020 · 4 comments
Open

Translations / Missing en_US translations #86

DiabolicAngeL opened this issue Jul 16, 2020 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DiabolicAngeL
Copy link

DiabolicAngeL commented Jul 16, 2020

1. From config.json the English Language is missing the following:

      "APP_MESSAGE_MESS_SMS": "SMS",
      "APP_MESSAGE_MESS_CALL": "Call",
      "APP_MESSAGE_MESS_COPY": "Copy",
      "APP_MESSAGE_SEND_PHOTO": "Send a photo",

image


image

{id:4,title:e.IntlString("Añadir contacto"),icons:"fa-undo"} IN gcphone/html/static/js/app.js


2. Cancel/abort is not translated properly in English

image

I'll update here if I find more.

@DmACKGL
Copy link
Collaborator

DmACKGL commented Jul 16, 2020

Not Completely fixed. Reopening this issue.

@DmACKGL DmACKGL reopened this Jul 16, 2020
@DmACKGL DmACKGL added bug Something isn't working good first issue Good for newcomers labels Jul 16, 2020
@DmACKGL DmACKGL self-assigned this Jul 16, 2020
@recso
Copy link

recso commented Jul 17, 2020

hey @DiabolicAngeL could you send me your "config.json" from "html/static/config" i'd like to see how it worked for you cuz mine didn't work
"serviceCall": [{
"display": "Police",
"icon": "/html/static/img/icons_app/policia.png",
"subMenu": [{
"title": "Send a message",
"eventName": "esx_addons_gcphone:call",
"type": {
"number": "police"
}
},
{
"title": "Call emergency number",
"eventName": "gcphone:autoCallNumber",
"type": {
"number": "911"
}
}
]
},
{
"display": "Ambulance",
"backgroundColor": "red",
"icon": "/html/static/img/icons_app/lsfd.png",
"subMenu": [{
"title": "Send a message",
"eventName": "esx_addons_gcphone:call",
"type": {
"number": "ambulance"
}
}]
},
{
"display": "Mechanic",
"backgroundColor": "blue",
"icon": "/html/static/img/icons_app/mechanic.png",
"subMenu": [{
"title": "Send a message",
"eventName": "esx_addons_gcphone:call",
"type": {
"number": "mechanic"
}
}]
},
{
"display": "Taxi",
"backgroundColor": "yellow",
"icon": "/html/static/img/icons_app/taxi.png",
"subMenu": [{
"title": "Send a message",
"eventName": "esx_addons_gcphone:call",
"type": {
"number": "taxi"
}
}]
}
],

@DiabolicAngeL
Copy link
Author

DiabolicAngeL commented Jul 17, 2020

@recso https://pastebin.com/Y0whd1Av

Do not forget to add your images in fxmanifest.lua

@Mane48
Copy link

Mane48 commented Jul 22, 2020

Hi Ive noticed this issue my self and got to fixing it :D

I fixed several issues I noticed. There is several lines missing in between the languages in the config.js.
Ive also noticed that in the app.js when you are deleting the contact it will display french words, I changed that my self to be detected by the language you have selected.
I didnt fix all the languages but probably fixed the important one which is english.

static.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants