-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs/Tab - missing padding between Tab Control & Tab Content #126
Comments
Tested this across both Chrome and Safari. |
Example: If the idea is that each |
By default Tabs do not have padding-top to allow something like this, my idea was that you provide padding on children: <Tabs>
<Tab><div style={{ paddingTop: 20 }}>My children</div></Tab>
</Tabs> But I see, how it can be confusing, I'll add |
I only noticed because there previously was padding in 1.3. https://codesandbox.io/s/mantine-tab-padding-zqo3e?file=/src/App.js -- flick between the versions. |
Yes, that's changed in 2.0.0, I forgot to put it in changelog, anyway I'll add |
Thanks again for the great release! |
Resolved with #135 |
Question on
Tabs
, there previously was padding between the tab bar and the tab content.Do we now need to use the Styles API to inject some padding, or is the below a bug.
No padding at all - which is strange because even in the docs there is padding.
See the highlighted text butts up against the outline tab bar.
This is happening across all the tabs in my app (using mix of default and outline variants).
My App (seems broken):
Mantin Docs (works correctly!):
The immediate child inside the
<Tab>
is a<form>
- but not sure why that would make a difference.Other tabs which are affected have
<Text>
or vanilla<div>
as the immediate children.Code for my screenshot:
The text was updated successfully, but these errors were encountered: