Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does it support go routine and connect pool #3

Open
li-bit opened this issue Dec 26, 2019 · 3 comments
Open

does it support go routine and connect pool #3

li-bit opened this issue Dec 26, 2019 · 3 comments

Comments

@li-bit
Copy link

li-bit commented Dec 26, 2019

No description provided.

@manticoresearch
Copy link
Contributor

Can you please provide more details (or some code example) on the functionality that you think is missing?
In theory:

  • go routine - yes, should be not a problem
  • connect pool - not clear what you mean

@tangxinfa
Copy link

After read the code, we can figure out:
manticore.Client is not go routine safe, it's just a thin wrap on a
net.Conn. We should build a pool of manticore.Client objects if we want
access manticore server concurrently. If manticore server restarted, the
connection will lost, and we must make sure manticore.Client reconnect afterwards.

@tangxinfa
Copy link

manticore.Client.Ping() will cause the connection disconnected, how to detect the connection is alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants