Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure for python 2.7 #320

Closed
manodeep opened this issue Jul 2, 2024 · 4 comments
Closed

CI failure for python 2.7 #320

manodeep opened this issue Jul 2, 2024 · 4 comments

Comments

@manodeep
Copy link
Owner

manodeep commented Jul 2, 2024

General information

  • Corrfunc version: Any
  • platform:osx-arm64
  • installation method (pip/source/other?): N/A

Issue description

The latest dependabot PR highlighted that CI is not running on osx-arm64 for python2.7. Given that Corrfunc supports python2.7, CI should run

Expected behavior

CI runs

Actual behavior

CI fails on osx-arm64. One failure is for py2.7, while others are for py3.7 and numpy1.16

What have you tried so far?

N/A

Minimal failing example

N/A

@lgarrison Maybe it's time to drop python2.7 and adopt a policy to update the minimum versions of required dependencies.

@lgarrison
Copy link
Collaborator

+1 for dropping Python 2.7! I usually target non-EOL Python releases (currently 3.8-3.12) in my projects. I doubt we've made any changes that would directly affect the minimum versions of other dependencies, but if we bump the minimum Python version, we might at least need to bump the minimum NumPy version.

@manodeep
Copy link
Owner Author

manodeep commented Jul 2, 2024

I asked on Twitter - in case someone has a real strong need/justification for python2.7

@manodeep
Copy link
Owner Author

manodeep commented Jul 3, 2024

(Completely biased) Twitter sample of two (so far) suggests that dropping py2.7 is fine

@manodeep
Copy link
Owner Author

manodeep commented Aug 7, 2024

Python2.7 has been dropped from the CI - so this issue is fixed (more accurately, not relevant)

@manodeep manodeep closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants