GithubPRPlanPlugin Max Comment Issue

[codezninja]

When the plan to post is more than the max character the pipeline will fail. The error is not very informative. When posting Jenkins only returns ERROR: Creating GitHub comment failed: HTTP/2 422

When running the body manually in verbose mode was I able to determine the actually error was

{
  "message": "Validation Failed",
  "errors": [
    {
      "resource": "IssueComment",
      "code": "unprocessable",
      "field": "data",
      "message": "Body is too long (maximum is 65536 characters)"
    }
  ],
  "documentation_url": "https://docs.github.com/enterprise/3.1/rest/reference/issues#create-an-issue-comment"
}

Proposal

1. We break up the body txt into multiple posts.
2. We don't hard fail if the body.txt is over a certain size and just skip the PR posting and echo out that error

[kmanning]

Interesting, the code seems to indicate that that should already be happening:

https://github.com/manheim/terraform-pipeline/blob/master/src/GithubPRPlanPlugin.groovy#L170-L171