Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Menus do not show items #260

Open
FabioMC opened this issue Jun 20, 2021 · 3 comments
Open

More Menus do not show items #260

FabioMC opened this issue Jun 20, 2021 · 3 comments

Comments

@FabioMC
Copy link

FabioMC commented Jun 20, 2021

After I compiled the last firmware the "More" menu on "Tools" only presents a icon called G-Code. All the others icons like preheat PLA, preheat ABS, and all the others configured on configuration_adv is not present.

IMG_0149

This is how my configuration_adv is right now.
// Custom Menu: Main Menu
#define CUSTOM_MENU_MAIN
#if ENABLED(CUSTOM_MENU_MAIN)
#define CUSTOM_MENU_MAIN_TITLE "Custom Commands"
#define CUSTOM_MENU_MAIN_SCRIPT_DONE "M117 User Script Done"
#define CUSTOM_MENU_MAIN_SCRIPT_AUDIBLE_FEEDBACK
#define CUSTOM_MENU_MAIN_SCRIPT_RETURN // Return to status screen after a script
#define CUSTOM_MENU_MAIN_ONLY_IDLE // Only show custom menu when the machine is idle

#define MAIN_MENU_ITEM_1_DESC "Home & UBL Info"
#define MAIN_MENU_ITEM_1_GCODE "G28\nG29 W"
//#define MAIN_MENU_ITEM_1_CONFIRM // Show a confirmation dialog before this action

#define MAIN_MENU_ITEM_2_DESC "Preheat for " PREHEAT_1_LABEL
#define MAIN_MENU_ITEM_2_GCODE "M140 S" STRINGIFY(PREHEAT_1_TEMP_BED) "\nM104 S" STRINGIFY(PREHEAT_1_TEMP_HOTEND)
//#define MAIN_MENU_ITEM_2_CONFIRM

#define MAIN_MENU_ITEM_3_DESC "Preheat for " PREHEAT_2_LABEL
#define MAIN_MENU_ITEM_3_GCODE "M140 S" STRINGIFY(PREHEAT_2_TEMP_BED) "\nM104 S" STRINGIFY(PREHEAT_2_TEMP_HOTEND)
//#define MAIN_MENU_ITEM_3_CONFIRM

//#define MAIN_MENU_ITEM_4_DESC "Heat Bed/Home/Level"
//#define MAIN_MENU_ITEM_4_GCODE "M140 S" STRINGIFY(PREHEAT_2_TEMP_BED) "\nG28\nG29"
//#define MAIN_MENU_ITEM_4_CONFIRM

//#define MAIN_MENU_ITEM_5_DESC "Home & Info"
//#define MAIN_MENU_ITEM_5_GCODE "G28\nM503"
//#define MAIN_MENU_ITEM_5_CONFIRM
#endif

@Valnar8
Copy link

Valnar8 commented Jun 21, 2021

There is already a thread for this
MarlinFirmware/Marlin#21423 (comment)

@javicarrera
Copy link

I think I have found the reason for this problem.
With this commit #18177 definitions for custom user menus were changed in Marlin.

#define CUSTOM_USER_MENUS
#define USER_DESC_1 ""
#define USER_GCODE_1 ""
was changed by:
#define CUSTOM_MENU_MAIN
#define MAIN_MENU_ITEM_1_DESC ""
#define MAIN_MENU_ITEM_1_GCODE ""

It is missing however changing those in conditionals_adv.h (CUSTOM_MENU_MAIN was changed, the other 2 not):
#if BOTH(HAS_TFT_LVGL_UI, CUSTOM_MENU_MAIN)
#define HAS_1(N) (defined(USER_DESC##N) && defined(USER_GCODE_##N))

Please if someone can change this line of code and I think the "more" menu will work again with LVGL UI.

@javicarrera
Copy link

In today's Marlin bugfix it is solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants