Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-848] fix: issue with parent child relation not being removed from update issue modal. #4103

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

prateekshourya29
Copy link
Collaborator

@prateekshourya29 prateekshourya29 commented Apr 1, 2024

Problem

Removing parent from issue edit modal pop up is not removing the parent child relation.

Solution

This was due to the use of SetValue to remove parent_id when we click on the cross icon. Our revalidation mode is set to onChange and due this the above logic was not working and dirtyFields was not showing parent_id as an updated field even if the relation was removed. To fix this, I have updated the logic to use <Controller /> component with its onChange prop to remove the relation.

This PR is linked to WEB-848

@prateekshourya29 prateekshourya29 self-assigned this Apr 1, 2024
@prateekshourya29 prateekshourya29 added 🐛bug Something isn't working 🌐frontend labels Apr 1, 2024
@pushya22 pushya22 added this to the v0.18.0-dev milestone Apr 2, 2024
@rahulramesha rahulramesha merged commit fed5916 into develop Apr 3, 2024
11 of 12 checks passed
@rahulramesha rahulramesha deleted the fix/issue-modal-parent-relation branch April 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants