Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kanban layout empty group toggle #3708

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: kanban layout empty group toggle #3708

merged 1 commit into from
Feb 20, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 20, 2024 •
edited
Loading

Problem

  • The toggle for displaying empty groups in the Kanban layout was not functioning properly.

Resolution

  • The root cause of the issue was that the showEmptyGroup property was not being passed to the Kanban group component. Additionally, I implemented the toggle logic to render the selected option, resolving the problem.

This PR is linked to [WEB-442].

Media

Before: After:
53bd392f-a246-4cdb-805b-f5f08b3f0f0c 10d0ddcc-278f-4a50-9aa5-4d3678f485c2

@anmolsinghbhatia anmolsinghbhatia added 🐛bug Something isn't working 🌐frontend labels Feb 20, 2024
@anmolsinghbhatia anmolsinghbhatia added this to the v0.16 milestone Feb 20, 2024
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review February 20, 2024 07:54
@sriramveeraghanta sriramveeraghanta merged commit c7db290 into develop Feb 20, 2024
8 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/kanban-layout-display-filters branch February 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@rahulramesha rahulramesha rahulramesha approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.16-dev
Development

Successfully merging this pull request may close these issues.
3 participants
@anmolsinghbhatia @sriramveeraghanta @rahulramesha