fix: Pages Malfunctioning on Load and Recent Pages Computation #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriramveeraghanta
requested changes
Jan 12, 2024
web/store/page.store.ts
Outdated
| return response; | ||
| }); | ||
| } catch (error) { | ||
| return []; |
There was a problem hiding this comment.
catch block should always throw the error message, to handle it at the component level. By returning an empty array we can never identify if the server value is empty or it is an error case.
sriramveeraghanta
approved these changes
Jan 12, 2024
sriramveeraghanta
changed the title
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix: fixed `usePage` hook returning context instead of IPageStore * fix: updated recent pages with `updated_at` instead of `created_at` * fix: thown error instead of returning empty array
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix: fixed `usePage` hook returning context instead of IPageStore * fix: updated recent pages with `updated_at` instead of `created_at` * fix: thown error instead of returning empty array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated_atinstead ofcreated_at.usePagehook, to returnIPageStoreinstead of the whole context.