fix: breaking cycle issues and replacing router.push with Links #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
web/components/command-palette/actions/workspace-settings-actions.tsx
Dismissed
Show dismissed
Hide dismissed
web/components/command-palette/actions/workspace-settings-actions.tsx
Dismissed
Show dismissed
Hide dismissed
web/components/command-palette/actions/workspace-settings-actions.tsx
Dismissed
Show dismissed
Hide dismissed
web/components/command-palette/actions/workspace-settings-actions.tsx
Dismissed
Show dismissed
Hide dismissed
web/components/command-palette/actions/workspace-settings-actions.tsx
Dismissed
Show dismissed
Hide dismissed
sriramveeraghanta
approved these changes
Jan 8, 2024
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in creating a new cycle, restructure the active cycles inside cycles store and review and replace router.pushes